From nobody Wed Sep 24 09:01:32 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cWrSD3lsXz68lhs; Wed, 24 Sep 2025 09:01:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cWrSD3Bgtz3ttP; Wed, 24 Sep 2025 09:01:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758704492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+TZwyYnHja/QX5t9Dm5vODU/NTnvxAhF8KlBrfhz0h4=; b=VGLL/fS6X+TS89YyEmElixEeIHqfSt3TiOopjsyjCLEoWmXw08maFCRZ3jBXhH5gIINbuR 7dy8wi9OI0HZlQ/zong1Xw+O2Em3sqxhy8sDPotK1PrKl3MmMaPTx4KgijIxEUr9B0MeOL 1GN/4gyZi9hOvRuEyO4Hq/K7AFhPexqeY+sJpH7pJ2nPz5c/mWEnZMqdk7JLGaI5QsoC1E JIzd64B3bmerRQ/QFyqFQchwqMSEAMS8Bc5rFNdAUP1PksZdjxvYiylOzLFuBCRQdPpOkY RDqj8ls2WA0A4UNJKmnB8aYk2ONnMeS8yPd+Rj+zMPZgSVbCECvnShz5/4xFLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758704492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+TZwyYnHja/QX5t9Dm5vODU/NTnvxAhF8KlBrfhz0h4=; b=SyFTKFEfMaGp6e8hbeRY7VjAHUAoKZ3GPablMnyARmM03Pacwkg6uFVmGKTN/j8GeLuV2N xWKdbktbv0UnbkQDCu1X3CFM2H4I1GFevDBvnJT3bR/PFRSlRzWC7jWaC1lMf8ORxQkLKP vMH/BaIxu5+5vYe22MOFPgsIlGkFTj+Ybg3dGyjfjSCKE8rl0b3p+SyFl72gRzUUYjWplq GCoWp23pp50my6YSud7ULXXb7b1XqGm71ivguwPLU9M+DW4d4jVWwKsho45+pFAJ1fBD0g ZDzNHVf6Aa0eZaminhGHhMw5SUpoDPPOpME97vVESmoxxCuJarmUUHN1yG/4jA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758704492; a=rsa-sha256; cv=none; b=D3s4ibkA9HvkfSz9yRZVOMB1JmIYx2ZhZ5iQJdoBZ+4zpH7GmfFguFUDY+GHoKYrlJ8MHh MI/+TkQ2L5j2I+JJ3e9MtRzsTXESCYJyOXOsYoE5ON6HMPZ9Nw8tIPGc/RG/gyMdB7OFxI iKW/4+7lt/zx3rpbJbKt2tQihF1LDfJ9kgbi2Vb9xWB7RL3KbwjoeAEydgmowehqGiskGn BY/Pk1B6yCm4eb3krpmUayFOksEvT/jHXl+3j43Twlp8vjeIKiOVPrraXjQXjmVCMAlVbo jKl43jt8cZaaxJaSjiPCUiFltXdnrTcYWV5BdnfhvYPP06IGg/0MjC/mp5Y7SA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cWrSD2kWzz9Dt; Wed, 24 Sep 2025 09:01:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58O91WLL079167; Wed, 24 Sep 2025 09:01:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58O91WZ1079164; Wed, 24 Sep 2025 09:01:32 GMT (envelope-from git) Date: Wed, 24 Sep 2025 09:01:32 GMT Message-Id: <202509240901.58O91WZ1079164@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 21d42c8d9022 - main - vfs: let the compiler catch unhandled vgetstate values in vget_abort List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 21d42c8d902235b90b59d1aea6203b12e40c6c1b Auto-Submitted: auto-generated The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=21d42c8d902235b90b59d1aea6203b12e40c6c1b commit 21d42c8d902235b90b59d1aea6203b12e40c6c1b Author: Mateusz Guzik AuthorDate: 2025-09-24 08:52:28 +0000 Commit: Mateusz Guzik CommitDate: 2025-09-24 08:52:28 +0000 vfs: let the compiler catch unhandled vgetstate values in vget_abort --- sys/kern/vfs_subr.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 9818c60ca387..73e110c05bc1 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -3352,13 +3352,22 @@ vget_abort(struct vnode *vp, enum vgetstate vs) switch (vs) { case VGET_USECOUNT: vrele(vp); - break; + goto out_ok; case VGET_HOLDCNT: vdrop(vp); + goto out_ok; + case VGET_NONE: break; - default: - __assert_unreachable(); } + + __assert_unreachable(); + + /* + * This is a goto label should the cases above have more in common than + * just the 'return' statement. + */ +out_ok: + return; } int