Date: Tue, 11 Oct 2022 04:24:31 +0000 From: Dennis Clarke <dclarke@blastwave.org> To: Warner Losh <imp@bsdimp.com> Cc: FreeBSD CURRENT <freebsd-current@freebsd.org>, riscv@freebsd.org Subject: Re: Has anyone tried to build QEMU from ports lately? Message-ID: <11c1eb3b-0ef4-2c2f-513e-6555346a67ea@blastwave.org> In-Reply-To: <fd8006d3-101d-9233-c75c-f9c2def95e91@blastwave.org> References: <4a476b1c-74e4-9cb8-17a4-202c81b2da1d@blastwave.org> <CANCZdfp%2BxxCdby9CtazACk3Ea2-1ZM_yDkiF=YSzvg_qU2kVvA@mail.gmail.com> <CANCZdfqEKiraHF2Yq1ngW2rXU399yA=pJZEd6ipbWPVO-9_%2B4Q@mail.gmail.com> <fd8006d3-101d-9233-c75c-f9c2def95e91@blastwave.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/11/22 04:20, Dennis Clarke wrote: > On 10/10/22 17:53, Warner Losh wrote: >> On Mon, Oct 10, 2022 at 10:56 AM Warner Losh <imp@bsdimp.com> wrote: >> >>> I know what's causing this problem. I'll resolve. >>> >>> tl/dr: _pv_entry.h depends on sys/param.h being included before its use. >>> >> >> https://reviews.freebsd.org/D36927 fixes it by making sys/_pv_entry.h >> more >> self-contained and less reliant on param.h pollution. The kernel includes >> that >> everywhere it's used, but userland is more hit or miss because >> machine/pmap.h >> isn't a well defined interface, but is needed for some things sometimes. >> > > I am not sure where this is related, however, there is a change in QEMU: > > > https://github.com/qemu/qemu/commit/a4a9a4432e2bf280a989ca344466d7375db7993f > > > > Which seems to provide a way around some really long ISA cpu name data > that gets caught in sys/riscv/riscv/identcpu.c at around line 113 or > so : > > Forgot to mention : https://github.com/qemu/qemu/blob/master/hw/riscv/virt.c#L248 I wonder what the string is that tossed the KASSERT. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11c1eb3b-0ef4-2c2f-513e-6555346a67ea>