From owner-svn-src-all@FreeBSD.ORG Mon Oct 28 21:17:02 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 56AD52AD; Mon, 28 Oct 2013 21:17:02 +0000 (UTC) (envelope-from jlh@FreeBSD.org) Received: from caravan.chchile.org (caravan.chchile.org [178.32.125.136]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1EE202EE0; Mon, 28 Oct 2013 21:17:02 +0000 (UTC) Received: by caravan.chchile.org (Postfix, from userid 1000) id 7F34EC2965; Mon, 28 Oct 2013 21:17:00 +0000 (UTC) Date: Mon, 28 Oct 2013 22:17:00 +0100 From: Jeremie Le Hen To: Adam McDougall Subject: Re: svn commit: r254974 - in head: etc/defaults etc/periodic/monthly etc/periodic/security etc/periodic/weekly share/man/man5 Message-ID: <20131028211700.GB37879@caravan.chchile.org> Mail-Followup-To: Adam McDougall , svn-src-all@freebsd.org References: <201308272120.r7RLKTvk066897@svn.freebsd.org> <20131021000110.GJ2097@egr.msu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131021000110.GJ2097@egr.msu.edu> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Jeremie Le Hen , svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2013 21:17:02 -0000 Hi Adam, On Sun, Oct 20, 2013 at 08:01:10PM -0400, Adam McDougall wrote: > Thanks for working on this, I look forward to taking advantage of it! > > I have a system with some old style adjustments in periodic.conf but > the compat shim doesn't seem to be working (it is running r255793). > I filed PR conf/183137 with more details. Sorry for the late reply, I was abroad. Can you test the following patch please? Index: etc/defaults/periodic.conf =================================================================== --- etc/defaults/periodic.conf (revision 255169) +++ etc/defaults/periodic.conf (working copy) @@ -319,7 +319,7 @@ security_daily_compat_var() { local var=$1 dailyvar value - dailyvar=daily_status_security${#status_security} + dailyvar=daily_status_security${var#status_security} periodvar=${var%enable}period eval value=\"\$$dailyvar\" [ -z "$value" ] && return -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons.