From owner-freebsd-current@FreeBSD.ORG  Fri Nov 19 12:40:55 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id 1CFC3106566B; Fri, 19 Nov 2010 12:40:55 +0000 (UTC)
Date: Fri, 19 Nov 2010 12:40:55 +0000
From: Alexander Best <arundel@freebsd.org>
To: Sergey Kandaurov <pluknet@gmail.com>
Message-ID: <20101119124055.GA11368@freebsd.org>
References: <20101118231411.GA5121@freebsd.org>
	<AANLkTi=opRz6iP8_-KR9uM904KHRnR6NkDu6o75Uet+v@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTi=opRz6iP8_-KR9uM904KHRnR6NkDu6o75Uet+v@mail.gmail.com>
Cc: freebsd-current@freebsd.org
Subject: Re: old references to vfs_mountroot_try()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Nov 2010 12:40:55 -0000

On Fri Nov 19 10, Sergey Kandaurov wrote:
> On 19 November 2010 02:14, Alexander Best <arundel@freebsd.org> wrote:
> > hi there,
> >
> > vfs_mountroot_try() seems to have been removed, yet the src still contains
> > three references to it:
> >
> > vfs_mount.c:386
> > vfs_mount.c:723
> > freebsd32_misc.c:2368
> >
> 
> So, what about just to rename those comments to reflect function name change?

that looks fine. i don't know anything about vfs, so i simply figured out that
the reference to vfs_mountroot_try() was not right anymore, but couldn't find
where MNT_ROOTFS is now being set.

...so its parse_mount(). :)

could you commit that?

cheers.
alex

> 
> Index: sys/kern/vfs_mount.c
> ===================================================================
> --- sys/kern/vfs_mount.c        (revision 215516)
> +++ sys/kern/vfs_mount.c        (working copy)
> @@ -383,7 +383,7 @@
>          * Filter out MNT_ROOTFS.  We do not want clients of nmount() in
>          * userspace to set this flag, but we must filter it out if we want
>          * MNT_UPDATE on the root file system to work.
> -        * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
> +        * MNT_ROOTFS should only be set in the kernel in parse_mount().
>          */
>         uap->flags &= ~MNT_ROOTFS;
> 
> @@ -720,7 +720,7 @@
>          * Filter out MNT_ROOTFS.  We do not want clients of mount() in
>          * userspace to set this flag, but we must filter it out if we want
>          * MNT_UPDATE on the root file system to work.
> -        * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
> +        * MNT_ROOTFS should only be set in the kernel in parse_mount().
>          */
>         uap->flags &= ~MNT_ROOTFS;
> 
> Index: sys/compat/freebsd32/freebsd32_misc.c
> ===================================================================
> --- sys/compat/freebsd32/freebsd32_misc.c       (revision 215516)
> +++ sys/compat/freebsd32/freebsd32_misc.c       (working copy)
> @@ -2365,7 +2365,7 @@
>          * Filter out MNT_ROOTFS.  We do not want clients of nmount() in
>          * userspace to set this flag, but we must filter it out if we want
>          * MNT_UPDATE on the root file system to work.
> -        * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
> +        * MNT_ROOTFS should only be set in the kernel in parse_mount().
>          */
>         uap->flags &= ~MNT_ROOTFS;
> 
> -- 
> wbr,
> pluknet

-- 
a13x