Date: Tue, 07 May 2019 10:00:05 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Ed Maste <emaste@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r347228 - head/sys/kern Message-ID: <DAC62DC7-D87E-4E52-B37B-9385E39F8D1C@panasas.com> In-Reply-To: <201905071617.x47GHXB0065438@repo.freebsd.org> References: <201905071617.x47GHXB0065438@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> + # Avoid a literal generated file tag here. > + generated =3D "@" "generated"; > + Why is that needed here, but not in r347224? -Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: <owner-src-committers@freebsd.org> on behalf of Ed Maste <emaste@Free= BSD.org> Date: 2019-05-07, Tuesday at 09:17 To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@= freebsd.org> Subject: svn commit: r347228 - head/sys/kern Author: emaste Date: Tue May 7 16:17:33 2019 New Revision: 347228 URL: https://svnweb.freebsd.org/changeset/base/347228 Log: makesyscalls: use @generated tag in generated files =20 Multiple tools use @generated to identify generated files (for example, in a review Phabricator will by default hide diffs in generated files). Use the @generated tag in makesyscalls.sh as we've done for other generated files. =20 Reviewed by: cem MFC after: 1 month Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D20183 Modified: head/sys/kern/makesyscalls.sh Modified: head/sys/kern/makesyscalls.sh =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D --- head/sys/kern/makesyscalls.sh Tue May 7 15:03:26 2019 (r347227) +++ head/sys/kern/makesyscalls.sh Tue May 7 16:17:33 2019 (r347228) @@ -142,18 +142,21 @@ sed -e ' capenabled_string =3D \"$capenabled\" "' =20 + # Avoid a literal generated file tag here. + generated =3D "@" "generated"; + split(capenabled_string, capenabled, ","); =20 printf "\n/* The casts are bogus but will do for now. */\n" > sysent printf "struct sysent %s[] =3D {\n",switchname > sysent =20 printf "/*\n * System call switch table.\n *\n" > syssw - printf " * DO NOT EDIT-- this file is automatically generated.\n" > syss= w + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = syssw printf " * $%s$\n", "FreeBSD" > syssw printf " */\n\n" > syssw =20 printf "/*\n * System call prototypes.\n *\n" > sysarg - printf " * DO NOT EDIT-- this file is automatically generated.\n" > sysa= rg + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = sysarg printf " * $%s$\n", "FreeBSD" > sysarg printf " */\n\n" > sysarg printf "#ifndef %s\n", sysproto_h > sysarg @@ -187,23 +190,23 @@ sed -e ' printf "\n#ifdef %s\n\n", compat11 > syscompat11 =20 printf "/*\n * System call names.\n *\n" > sysnames - printf " * DO NOT EDIT-- this file is automatically generated.\n" > sysn= ames + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = sysnames printf " * $%s$\n", "FreeBSD" > sysnames printf " */\n\n" > sysnames printf "const char *%s[] =3D {\n", namesname > sysnames =20 printf "/*\n * System call numbers.\n *\n" > syshdr - printf " * DO NOT EDIT-- this file is automatically generated.\n" > sysh= dr + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = syshdr printf " * $%s$\n", "FreeBSD" > syshdr printf " */\n\n" > syshdr =20 printf "# FreeBSD system call object files.\n" > sysmk - printf "# DO NOT EDIT-- this file is automatically generated.\n" > sysmk + printf "# DO NOT EDIT-- this file is automatically " generated ".\n" > s= ysmk printf "# $%s$\n", "FreeBSD" > sysmk printf "MIASM =3D " > sysmk =20 printf "/*\n * System call argument to DTrace register array converstion= .\n *\n" > systrace - printf " * DO NOT EDIT-- this file is automatically generated.\n" > syst= race + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = systrace printf " * $%s$\n", "FreeBSD" > systrace printf " * This file is part of the DTrace syscall provider.\n */\n\n" >= systrace printf "static void\nsystrace_args(int sysnum, void *params, uint64_t *u= arg, int *n_args)\n{\n" > systrace
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DAC62DC7-D87E-4E52-B37B-9385E39F8D1C>