From owner-freebsd-hardware Fri Feb 8 10:11:51 2002 Delivered-To: freebsd-hardware@freebsd.org Received: from avocet.prod.itd.earthlink.net (avocet.mail.pas.earthlink.net [207.217.120.50]) by hub.freebsd.org (Postfix) with ESMTP id 9647437B404; Fri, 8 Feb 2002 10:11:39 -0800 (PST) Received: from pool0031.cvx22-bradley.dialup.earthlink.net ([209.179.198.31] helo=mindspring.com) by avocet.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16ZFUb-0002PY-00; Fri, 08 Feb 2002 10:11:28 -0800 Message-ID: <3C641347.ADE06FAD@mindspring.com> Date: Fri, 08 Feb 2002 10:04:55 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Oliver Fromme Cc: "Eugene M. Kim" , Oliver Fromme , FreeBSD Hardware Mailing List , FreeBSD Hackers Mailing List Subject: Re: USB "Memorybird" quirks References: <200202081724.g18HOlZ40937@lurza.secnetix.de> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hardware@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Oliver Fromme wrote: > > Could this be "auto-quirked"? [ ... ] > It seems to me that umass_scsi_transform() in umass.c is > the place intended for this kind of things. After the > first failure (which is detected in umass_bbb_state()), > a flag (quirk) should be set in the softc, and afterwards > umass_scsi_transform should translate 6-byte commands to > 10-byte commands. Doesn't sound too complicated to me. After looking at the code in more detail, then puzzling and puzzling 'til mu puzzler was sore, then sitting back down, and puzzling some more... It very obviously needs to be generic in the CAM layer in the da handler, since it's applicable to all devices in the quirks table, not just the USB devices. It still needs a failuter trace from the CAM_DEBUG stuff. Strange as it may seem, I look through quirks lists before I buy hardware, and if it has a quirk, I don't buy it. So I'm not in a position to run the test, or test a fix. The USB stuff still needs to retry more than it does, though, if those logs were an accurate retry count, or the fix of automatically moving from 6->10 byte commands won't work transparently, and you'll end up having to do the disklabel a couple of times before it sticks. This is pretty unacceptable behaviour (it violates POLA all to heck). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hardware" in the body of the message