From owner-svn-src-all@freebsd.org Tue Jun 9 14:26:06 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D0F0532ED17; Tue, 9 Jun 2020 14:26:06 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49hC8t0cWZz3SwS; Tue, 9 Jun 2020 14:26:05 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x429.google.com with SMTP id c3so21523219wru.12; Tue, 09 Jun 2020 07:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=h8o4blXwzfFfG8ivDcyU3CaU17w0OVG2LBdZ9+ksPwE=; b=Yp03E0u8seyfsXcDOKNKdxwqQEnE2zndAHK0LU5J2wb1z+FaZ4NM2XfZSL/F0LftbS UelvU01D9klsMBph/gyCzpicWJKNbfy2BHCoUOFGwFjv/Di6VBhHfAqVBWu2Is3phITD hMK+gkBB9xiObuxSFrR53SMOM0iMvZ3eWjlgjuphJ/0z+z81xPpWyHaL967lzUuErKuC JdyY2tfXxPunlpN58g2nB/+PQSEkaNRAzv1OIbUsqiruJH+0lrahhDi6MD8DwieU5neJ +ph3yobck1x4BQzZfmB5yHoLpWDcUtZVio2f62A+ZpE6qWkiBe3cJ1MyB42VspTcMC4j LPPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=h8o4blXwzfFfG8ivDcyU3CaU17w0OVG2LBdZ9+ksPwE=; b=kb2qkB1T69CFXpyzvvMdRNT7SlbwU7NICGVXsCoaS3T4vSoi4TeBkzSH2GSQoI1YPL IXYxHbBJkc1/eadOvluXjD0uzNAa0UXxV7t4aAcvkEuWXFJ4fJiqOpoa8Gfdg5kAvc+/ dzXgj9xb7ixMs3S744/iC4jkt7n942n+h9uNrpUlY+yRBcN1azeoHAe9Wcx+FL0+1lpy EAq1k/jChLcbU9bGo6Rv2eTs8MdR4xNwtmdQE2UN/uhpr+cOKNuiTIKa8TnxNIvgU4oV 30zeQbTY6EVRDL4GUPBaanqOtn7nvhTQXXNWknFE65ylaPLWMs199I5z+f3rg6xh6+HB oebA== X-Gm-Message-State: AOAM531zzil+7UiU0PrDTm63Usa4k9pw8ZxQGPVus/gmiz8Bh5KFJffs 2vzRQ3gl1/OnTy7N4SSSozQb1rsy/hw6NEvnf8cm+gr4 X-Google-Smtp-Source: ABdhPJxC1i0LAhnyXWa9tzMji+Zi3WZo3QzSi5qdx1Y7IDSI/qWO4E+OSoNbm59me/sxwcIw30BdhNSCbuWY8OfDxA4= X-Received: by 2002:a05:6000:18c:: with SMTP id p12mr5114719wrx.66.1591712764293; Tue, 09 Jun 2020 07:26:04 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:fd8f:0:0:0:0:0 with HTTP; Tue, 9 Jun 2020 07:26:03 -0700 (PDT) In-Reply-To: <202006070457.0574vm7f075947@repo.freebsd.org> References: <202006070457.0574vm7f075947@repo.freebsd.org> From: Mateusz Guzik Date: Tue, 9 Jun 2020 16:26:03 +0200 Message-ID: Subject: Re: svn commit: r361885 - head/sys/net80211 To: Adrian Chadd Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 49hC8t0cWZz3SwS X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Yp03E0u8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::429 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.09 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.985]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; NEURAL_HAM_LONG(-1.03)[-1.026]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::429:from]; NEURAL_HAM_SHORT(-0.08)[-0.081]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2020 14:26:06 -0000 On 6/7/20, Adrian Chadd wrote: > Author: adrian > Date: Sun Jun 7 04:57:48 2020 > New Revision: 361885 > URL: https://svnweb.freebsd.org/changeset/base/361885 > > Log: > [net80211] Add a method to return the vap's ifname. > > This removes the requirement to know what's in the ifp. > > (If someone wants a quick clean-up task, it'd be nice to convert > instances > of ifp dereferencing for if_xname over to this method.) > > Modified: > head/sys/net80211/ieee80211_freebsd.c > head/sys/net80211/ieee80211_freebsd.h > > Modified: head/sys/net80211/ieee80211_freebsd.c > ============================================================================== > --- head/sys/net80211/ieee80211_freebsd.c Sun Jun 7 04:32:38 > 2020 (r361884) > +++ head/sys/net80211/ieee80211_freebsd.c Sun Jun 7 04:57:48 > 2020 (r361885) > @@ -1034,6 +1034,20 @@ wlan_iflladdr(void *arg __unused, struct ifnet *ifp) > } > > /* > + * Fetch the VAP name. > + * > + * This returns a const char pointer suitable for debugging, > + * but don't expect it to stick around for much longer. > + */ > +const char * > +ieee80211_get_vap_ifname(struct ieee80211vap *vap) > +{ > + if ((vap->iv_ifp == NULL) || (vap->iv_ifp->if_xname == NULL)) > + return "(none)"; > + return vap->iv_ifp->if_xname; > +} > + This gives me: /usr/src/sys/net80211/ieee80211_freebsd.c:1045:45: warning: comparison of array 'vap->iv_ifp->if_xname' equal to a null pointer is always false [-Wtautological-pointer-compare] if ((vap->iv_ifp == NULL) || (vap->iv_ifp->if_xname == NULL)) -- Mateusz Guzik