From owner-freebsd-stable@FreeBSD.ORG Fri Nov 19 10:21:36 2010 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C8F6106564A; Fri, 19 Nov 2010 10:21:36 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [IPv6:2001:470:a803::1]) by mx1.freebsd.org (Postfix) with ESMTP id D37648FC13; Fri, 19 Nov 2010 10:21:33 +0000 (UTC) Received: from mail.geekcn.org (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 91DB0A6B818; Fri, 19 Nov 2010 18:21:24 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by mail.geekcn.org (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with LMTP id x05vrgW3OwMf; Fri, 19 Nov 2010 18:21:13 +0800 (CST) Received: from delta.delphij.net (c-76-102-26-215.hsd1.ca.comcast.net [76.102.26.215]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 6E48DA6B785; Fri, 19 Nov 2010 18:21:10 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=bbaOLtaDrTq7gY5RuFL18Un2WNO7zuSXlGyv5Ryd1mwsMe5CVVWjTU0J7gbbDMugc NXiAaL3cOTmXSQKuVq1uA== Message-ID: <4CE64F91.3060807@delphij.net> Date: Fri, 19 Nov 2010 02:21:05 -0800 From: Xin LI Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.15) Gecko/20101028 Thunderbird/3.0.10 ThunderBrowse/3.3.2 MIME-Version: 1.0 To: Jeremy Chadwick References: <201011191044.oAJAixSZ055707@freebsd-legacy.sentex.ca> <20101119100057.GA60825@icarus.home.lan> In-Reply-To: <20101119100057.GA60825@icarus.home.lan> X-Enigmail-Version: 1.0.1 OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: stable@freebsd.org, delphij@freebsd.org Subject: Re: [releng_7 tinderbox] failure on amd64/amd64 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2010 10:21:36 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/19/10 02:00, Jeremy Chadwick wrote: > On Fri, Nov 19, 2010 at 10:44:59AM +0000, FreeBSD Tinderbox wrote: >> ===> usr.bin/nc (all) >> cc -O2 -fno-strict-aliasing -pipe -DIPSEC -c /src/usr.bin/nc/../../contrib/netcat/netcat.c >> /src/usr.bin/nc/../../contrib/netcat/netcat.c: In function 'remote_connect': >> /src/usr.bin/nc/../../contrib/netcat/netcat.c:573: error: 'IP_BINDANY' undeclared (first use in this function) >> /src/usr.bin/nc/../../contrib/netcat/netcat.c:573: error: (Each undeclared identifier is reported only once >> /src/usr.bin/nc/../../contrib/netcat/netcat.c:573: error: for each function it appears in.) >> *** Error code 1 > > This has been broken for 24 hours, and only on RELENG_7 (for all > architectures, not just amd64), which lacks IP_BINDANY capability: > > http://www.freebsd.org/cgi/cvsweb.cgi/src/contrib/netcat/netcat.c#rev1.6.2.2 Fixed in r215514. Sorry for that. > The committer and/or author needs to #ifdef IP_BINDANY the relevant > setsockopt() call for the RELENG_7 branch, or even both RELENG_7 and > RELENG_8 if they want. > > This original methodology was in the code (for SO_BINDANY), but was for > some reason removed. > > http://www.freebsd.org/cgi/cvsweb.cgi/src/contrib/netcat/netcat.c.diff?r1=1.6.2.1;r2=1.6.2.2;f=h The #ifdef's were to keep OpenBSD specific code out from build, but I have realized later that we do have IP_BINDANY for ~ 1 year so I have decided to utilize that feature but never realized that it was never MFC'ed to RELENG_7 :( Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iQEcBAEBCAAGBQJM5k+RAAoJEATO+BI/yjfB9YMH/iax9sXZYM9ugbKgDWu25HZs v96qI1xgD10LS8m9YL0dpHU7pgaXLmHUPxBGlhigvIEBfyQwAOBYTfppv+WNBuzK 1esYDn2muoh3PNdPApldYkN8beX2bc/l6CHHaI0yWJuR21DExmYlsSlZwulwU1r5 Xu/maQ2tKdV8AFr5jPDoDNybHp/wdQIinnppoUeZ3RUCPfXngp0afbC7r84B5yIa 8W+fZBIDFJIGva4GPt7x3w3QKRpGyvXlExVssTUyf6uZb/v9ulsakFiQaoBPh1u5 yf898QHlB++zoSH9oeTTAeoeQDpQjcouV++Z1S5ukcP2lkY/EXrM0Nnt2Wnc4kU= =eszP -----END PGP SIGNATURE-----