From owner-freebsd-arch@FreeBSD.ORG Thu Sep 5 20:03:32 2013 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 74072A99; Thu, 5 Sep 2013 20:03:32 +0000 (UTC) (envelope-from outbackdingo@gmail.com) Received: from mail-ob0-x22f.google.com (mail-ob0-x22f.google.com [IPv6:2607:f8b0:4003:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 07BEB2CF3; Thu, 5 Sep 2013 20:03:31 +0000 (UTC) Received: by mail-ob0-f175.google.com with SMTP id xn12so2554492obc.34 for ; Thu, 05 Sep 2013 13:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=SHaFvhh8lssvSKV1E4SsAt8zp2JwoN3gARZAmmVmxOo=; b=JY6G+5yaf2npmPH7WETXgYB5SeUBs7r1No9FZn8BC+Ow4caV2MUFrUXna+vBVpHwlg oe/z1Fr7naF4pzBAgJq8Kcavqp4EDgBv2XVPkAGVr0ViZeSp6jPhchX0ByQtwQeI+4dM co4dW7s51O+iA5vhfLWfpPC+E856hu2+qSuxPlHZdiwlIvka3SJumuBA0LMctoo7sLqq rqkPgYcV15yLgoniJQSf5XwDpudh8WocC0heLmhD3LAQaY8lZ37wDzeOmKMNwbAxtBq2 Nl18lRc1Gw0+36KV0awj0rCZpCxsza3nCZUo0BWKf2m28ePv34ympne4Lej89GtnButP i3WQ== MIME-Version: 1.0 X-Received: by 10.182.101.198 with SMTP id fi6mr7741772obb.79.1378411411115; Thu, 05 Sep 2013 13:03:31 -0700 (PDT) Received: by 10.76.114.227 with HTTP; Thu, 5 Sep 2013 13:03:31 -0700 (PDT) In-Reply-To: <5228D1A6.4020405@quip.cz> References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> <5228D1A6.4020405@quip.cz> Date: Thu, 5 Sep 2013 16:03:31 -0400 Message-ID: Subject: Re: New iSCSI stack. From: Outback Dingo To: Miroslav Lachman <000.fbsd@quip.cz> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-scsi@freebsd.org, freebsd-current@freebsd.org, =?ISO-8859-2?Q?Edward_Tomasz_Napiera=B3a?= , Ivan Voras , freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 20:03:32 -0000 On Thu, Sep 5, 2013 at 2:47 PM, Miroslav Lachman <000.fbsd@quip.cz> wrote: > Edward Tomasz Napiera=B3a wrote: > >> Wiadomo=B6=E6 napisana przez Ivan Voras w dniu 5 wr= z >> 2013, o godz. 13:18: >> >>> On 05/09/2013 12:27, Edward Tomasz Napiera=B3a wrote: >>> >>>> Hello. At http://people.freebsd.org/~**trasz/cfiscsi-20130904.diffyou'll find >>>> a patch which adds the new iSCSI initiator and target, against >>>> 10-CURRENT. >>>> To use the new initiator, start with "man iscsictl". For the target - >>>> "man >>>> ctld". >>>> >>> >>> Just a naming question: "ctld" could mean anything, I'd parse it as a >>> "control deamon" or something like that. Could you name it something >>> which reminds the user of iscsi? Like iscsictld? >>> >> >> As the man page says, ctld is "CAM Target Layer / iSCSI target daemon". >> Sure, right now it's pretty iSCSI-specific, but it doesn't need to be - >> it can >> be extended to just manage CTL configuration (e.g. for Fibre Channel), >> or to support other CTL-backed storage protocols, such as FCoE. >> >> It's just a helper daemon for ctl(4) - thus, ctld(8). And in case someo= ne >> does "man -k iscsi", there is the "iSCSI target" in the manual page titl= e. >> > > I understand your explanation, but still thinking rc.conf variables are > really confusing and unintuitive: > > iscsid_enable > iscsictl_enable > ctld_enable > > I cannot tell what they control just by their names and the same apply fo= r > services names. > > "If I want to restart iscsi target, should I use 'service iscsid restart' > or 'service iscsictl restart'? ... oh wait, it should be 'service ctld > restart'" > > I think it should be more user friendly. Something as Apache 2.2.x has > httpd and httpd.conf, but users are using 'service apache22 restart' and > 'apache22_enable=3D"YES"', because there can be more "http" daemons. > > My $0.02 > > Just an FYI 10_CURRENT svn info Path: . Working Copy Root Path: /usr/src URL: http://svn.freebsd.org/base/head Relative URL: ^/head Repository Root: http://svn.freebsd.org/base Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f Revision: 255253 Node Kind: directory Schedule: normal Last Changed Author: sjg Last Changed Rev: 255253 Last Changed Date: 2013-09-05 11:57:26 -0400 (Thu, 05 Sep 2013) cc -O2 -pipe -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 -Qunused-argument= s -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/ctld.c cc -O2 -pipe -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 -Qunused-argument= s -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/discovery.c cc -O2 -pipe -I/usr/src/usr.sbin/ctld -I/usr/src/usr.sbin/ctld/../../sys -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 -Qunused-argument= s -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/kernel.c /usr/src/usr.sbin/ctld/kernel.c:762:35: error: incompatible integer to pointer conversion passing 'unsigned long long' to parameter of type 'const cap_rights_t *' (aka 'const struct cap_rights *') [-Werror,-Wint-conversion= ] error =3D cap_rights_limit(ctl_fd, CAP_IOCTL); ^~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:197:20: note: expanded from macro 'CAP_IOCTL' #define CAP_IOCTL CAPRIGHT(1, 0x0000000000000080ULL) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:53:28: note: expanded from macro 'CAPRIGHT' #define CAPRIGHT(idx, bit) ((1ULL << (57 + (idx))) | (bit)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:327:50: note: passing argument to parameter 'rights' here int cap_rights_limit(int fd, const cap_rights_t *rights); ^ 1 error generated. *** Error code 1 Stop. make[4]: stopped in /usr/src/usr.sbin/ctld > Miroslav Lachman > > ______________________________**_________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/**mailman/listinfo/freebsd-**current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@** > freebsd.org " >