From owner-svn-src-all@freebsd.org Tue Jul 16 20:44:47 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D038FB9FFC for ; Tue, 16 Jul 2019 20:44:47 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 749F7744E9 for ; Tue, 16 Jul 2019 20:44:47 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x843.google.com with SMTP id x22so16151045qtp.12 for ; Tue, 16 Jul 2019 13:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=s7U8u+9Jgaz8trmScOqB+mZR9YvYOO3Gqd/yCU8IkJk=; b=BLxyyS9njxhFWy2zuttRhEQQcN9/kt0GME+0ZHou/Pgf4MSRJY0DJiraX08X0p08oG GPnwEF+TxB3U+zdCDWCbsKd+TgD0D0K/QYJq4O0OT9uYfQka6wl0BShebyJrSQZiQsO7 RmLDRH5+/KFcNwwj5a0fnpqYaRsKjOYN2zvDMNCyGvPp4CozsYua8954ehG+bSiDqXk9 w9lNHTLQ+nb9bzx2KrM8oJ6y0usPbARv7YszBQVaZL/zCq0CsMeUA2eHMTYquEFscrE8 Z01d/HiHRNB4Xqbed5i7IfHmas4cNTBv944gc7yAkzUP4ixbPIRR2VxK+QRs21wM1tyc xeYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=s7U8u+9Jgaz8trmScOqB+mZR9YvYOO3Gqd/yCU8IkJk=; b=inbSi6rr89jQ6mmqU1SCZGDL0fSHOTIJOTfVpQdB93TJ4Aa9uKI1EUSai8JXGPFSBe FmU0QVucfA9FOetKF5WcPcslh14jeeKdZtnVoJlBNCKJ9lZQl5bnRabLfd0V19cgz+tf AENn30V3MZ5UQ1abSXhOkmDCiTvA+YyUOpbEmc5HEvsbCO1R7VF75Ip4TejcKUcEvkBn nHuwW26jiyaMUWUjRqvr1Mha+vEbN3+PXWGPhdlr321UJ6U7DbNr2SpJA++aLUh4joIO dh+RDhnUoRj31Tmtof7uN2ggujxaACBKJsMenqt5yBUIQ+/j7ZxM9Nw3XYZvH6+U2Ijm tw6g== X-Gm-Message-State: APjAAAXFIIurLCKWEaacJuGJ5ifncJKfzTNmDaSis42ZltEAZ0IW3Kou /j7L9bpyCXKyv0eRM0UIqH+fjw== X-Google-Smtp-Source: APXvYqxgPkT5VMBJ5g95+mYizRVThZi838BasDIGYSPv5d0qi2A5j/Fpugb8/FKfQWwEWZ5F73jO8A== X-Received: by 2002:ac8:7404:: with SMTP id p4mr24970729qtq.181.1563309886806; Tue, 16 Jul 2019 13:44:46 -0700 (PDT) Received: from mutt-hbsd ([151.196.118.239]) by smtp.gmail.com with ESMTPSA id m12sm9139964qkk.123.2019.07.16.13.44.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 13:44:46 -0700 (PDT) Date: Tue, 16 Jul 2019 16:44:45 -0400 From: Shawn Webb To: John Baldwin Cc: Brooks Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350049 - head/contrib/amd/amd Message-ID: <20190716204445.qyhccsp6cijkxslk@mutt-hbsd> References: <201907161603.x6GG38oZ020228@repo.freebsd.org> <20190716194454.odytcdjtlduliz6l@mutt-hbsd> <6ddf37a1-3b1a-2401-a338-36b6c8b9947d@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4xnewste4utnug75" Content-Disposition: inline In-Reply-To: <6ddf37a1-3b1a-2401-a338-36b6c8b9947d@FreeBSD.org> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 749F7744E9 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=BLxyyS9n; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::843 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-5.87 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; MX_GOOD(-0.01)[cached: alt1.aspmx.l.google.com]; NEURAL_HAM_SHORT(-0.97)[-0.965,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; IP_SCORE(-0.80)[ip: (1.67), ipnet: 2607:f8b0::/32(-3.17), asn: 15169(-2.45), country: US(-0.06)]; RECEIVED_SPAMHAUS_PBL(0.00)[239.118.196.151.zen.spamhaus.org : 127.0.0.10]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MID_RHS_NOT_FQDN(0.50)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 20:44:47 -0000 --4xnewste4utnug75 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2019 at 01:41:06PM -0700, John Baldwin wrote: > On 7/16/19 12:44 PM, Shawn Webb wrote: > > On Tue, Jul 16, 2019 at 04:03:08PM +0000, Brooks Davis wrote: > >> Author: brooks > >> Date: Tue Jul 16 16:03:08 2019 > >> New Revision: 350049 > >> URL: https://svnweb.freebsd.org/changeset/base/350049 > >> > >> Log: > >> Fix two mismatches between function declaration and definition. > >> =20 > >> In both cases, function pointer arguments were inconsistently declar= ed > >> and the result worked because of C's odd rules around function point= er > >> (de)references. With a stricter compiler these fail to compile. > >=20 > > And, with CFI applied to the kernel, would cause a panic. :) > >=20 > > Good catch and thanks for the great work! >=20 > How would an incorrect function prototype in userland cause a kernel pani= c? Another good catch! I misread the intent of the patch. Sorry for the line noise. --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --4xnewste4utnug75 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl0uNzcACgkQ/y5nonf4 4fpwPxAAo3YWTwjFpQ7wOTZNnZXbT/FbG/0BLpfZMGgoXFDtaHPv8M23g5ha6g3T BJcV7gCB9nL0fUN86qP0Q64eurm2BoCEJx9p6y6YOMHSPddRb3HZ76t0KrIkOgP0 KQf4eHLM7sX/1jRhdzaRk96rOI8Kq9BgkSc0AKiBg7IGIDf5eW+TLWjm/Hdkozvn ms1dx6YLtBD9IzQPadsbcQ8THEhkP34JnsY+A8gZLoXRUbfPbNTzJ0MAt/aj6n2h 2cS4UQpGaQf2s2GL4oXKmz8cjrl5MsVC+/MnB0APruvoW8KNqgNOFW6uxncaKBtO a1Lfd71Im5S4t9pGk6jdoOux8cj+OtaeYww/onKhCnZdkZAFfg4cfyKbHRLF+HX3 iAWbJmjj/h5+FMlnID6l8Net6ExWbcZag3yiJsh9fwD8lDrboHAIdXqhYqh1xz98 n7+wdW2sogwgyMI/9hFlEPlDGFUwUts3p04t9p5rARHkKCCBDbKz8FpFZWy7JC/w 15uJl6QhXQfbuegm5sgMjjpDvmbTk/sUQb6bohwBJ95UWp97RcVKwz34MZ5dnErj G2URwEJTXtA/nif6fGdgttAoQXTLHHh7egH46LGSP1q6VFPSU8BML/2F9QM99CrN 9z9Gqd26XAqZv6ZLnx/cI/UcWKgJhjdqVyWJxEQ3U559DHf6qRw= =xZj2 -----END PGP SIGNATURE----- --4xnewste4utnug75--