From owner-svn-src-all@freebsd.org Tue Nov 17 17:32:24 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9E3E046A4E6 for ; Tue, 17 Nov 2020 17:32:24 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CbCgW6ZKyz3C7h for ; Tue, 17 Nov 2020 17:32:23 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f52.google.com with SMTP id l1so23998050wrb.9 for ; Tue, 17 Nov 2020 09:32:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=kSVocQRoGgFdGKekngWPmDyT0DiNuq7bTMj5Ua/gifM=; b=t6G6bNu+8GrqyTwsYWhf42vG/k2A+0hq5pg18CErw2yU3tmSgkY8RDYb5WAMhFyjgH sMGm8+uI/InKzxnDJxc4YrvNft+k+AVRXsK3191UdU0GqemWaKYco5AxhsGChy+j5ekl eQFNQWvbZlFT60QrDKMBeCWFuEIWrtmQrzRanoePq7MiQ4iyY0O5Rtsw8T+zhI4mM8h+ sKJ7SVJ8vwWnRQmeY9/8Letct33G0LOAzQfBDhwWVYjbk/AdPgdrcTlFJajUeFi6nLgn wuwsFeuR8GfajCiP/4g9cuTzalwQqsFCVG/guhOhcsXYkSiMZWwRnWceE2v7pUQn25O5 Hwtw== X-Gm-Message-State: AOAM530zUDt1K0zr+e9ZMQH5xJ7c2uKkyJr94ViXuOPTC0mnXiAVc9b3 uz34gTD+vcLcds5WSl4ydMHAoLzJzCLUr4lC X-Google-Smtp-Source: ABdhPJyZd6GK7z1fkwwUC83+Cc7SiB5FmZQxLEYBEd9uQDtdwLDslaYEC1MFGcsWNfsynQhtDFGCrA== X-Received: by 2002:adf:9d49:: with SMTP id o9mr580343wre.413.1605634342247; Tue, 17 Nov 2020 09:32:22 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id a17sm31002731wra.61.2020.11.17.09.32.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2020 09:32:21 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: svn commit: r367771 - head/sbin/nvmecontrol From: Jessica Clarke In-Reply-To: <5C44DBA6-CBA2-49E9-8AFC-45C62664D2FD@freebsd.org> Date: Tue, 17 Nov 2020 17:32:21 +0000 Cc: src-committers , svn-src-all , svn-src-head Content-Transfer-Encoding: 7bit Message-Id: <5883B567-0E7D-475A-B04B-25774FB22A6C@freebsd.org> References: <202011171712.0AHHCS3V017391@repo.freebsd.org> <5C44DBA6-CBA2-49E9-8AFC-45C62664D2FD@freebsd.org> To: Adrian Chadd X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4CbCgW6ZKyz3C7h X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.221.52:from]; FREEFALL_USER(0.00)[jrtc27]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.221.52:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.52:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.52:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 17:32:24 -0000 On 17 Nov 2020, at 17:29, Jessica Clarke wrote: > On 17 Nov 2020, at 17:12, Adrian Chadd wrote: >> @@ -175,8 +176,7 @@ update_firmware(int fd, uint8_t *payload, int32_t payl >> errx(EX_OSERR, "unable to malloc %zd bytes", (size_t)max_xfer_size); >> >> while (resid > 0) { >> - size = (resid >= (int32_t)max_xfer_size) ? >> - max_xfer_size : resid; >> + size = (resid >= max_xfer_size) ? max_xfer_size : resid; > > MIN from the already-included sys/param.h? > > (Otherwise: you have an extra space after ?) Also why is off signed when it counts up from 0? Jess