From owner-cvs-all Tue Nov 20 13:11:21 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 4699237B61B; Tue, 20 Nov 2001 13:07:42 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id fAKL7WU24849; Tue, 20 Nov 2001 13:07:32 -0800 (PST) (envelope-from obrien) Date: Tue, 20 Nov 2001 13:07:32 -0800 From: "David O'Brien" To: John Baldwin , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/include atomic.h Message-ID: <20011120130732.A24794@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: <200111121657.fACGvYF20899@freefall.freebsd.org> <20011121075927.A74178@gsmx07.alcatel.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011121075927.A74178@gsmx07.alcatel.com.au>; from peter.jeremy@alcatel.com.au on Wed, Nov 21, 2001 at 07:59:27AM +1100 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Nov 21, 2001 at 07:59:27AM +1100, Peter Jeremy wrote: > On Mon, Nov 12, 2001 at 08:57:33AM -0800, John Baldwin wrote: > >jhb 2001/11/12 08:57:33 PST > > > > Modified files: > > sys/i386/include atomic.h > > Log: > > Use newer constraints for inline assembly for an operand that is both an > > input and an output by using the '+' modifier rather than listing the > > operand in both the input and output sections. > > This change still leaves the non-memory operand's constraint as "ir" > in all cases - this isn't correct for the char or short cases. I have > some old patches to fix this. Please dig them up if you can. I really suspect some of the problems with 'gcc -O2' may be due to bad ASM constraints. > In any case, -stable also needs the change to use "+". yes. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message