From owner-cvs-all Wed Feb 21 12:26:11 2001 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (flutter.freebsd.dk [212.242.40.147]) by hub.freebsd.org (Postfix) with ESMTP id 0426637B4EC; Wed, 21 Feb 2001 12:25:54 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.1/8.11.1) with ESMTP id f1LKPnx03557; Wed, 21 Feb 2001 21:25:49 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Ben Smithurst Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 In-Reply-To: Your message of "Wed, 21 Feb 2001 20:16:16 GMT." <20010221201615.A25231@comp.leeds.ac.uk> Date: Wed, 21 Feb 2001 21:25:49 +0100 Message-ID: <3555.982787149@critter> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20010221201615.A25231@comp.leeds.ac.uk>, Ben Smithurst writes: >Poul-Henning Kamp wrote: > >> Better, and more readable: >> >> error = function(a1, a2); >> if (error != 0) > >Well that's a matter of opinion, but I suppose it's easily changed. :-) >I figured there's enough use of 'if ((var = func()) != 0)' in FreeBSD >that everyone knows exactly what it does and yours isn't really any more >readable. But it can easily be changed if people generally agree with >you. The above form is generally more grep(1) and sed(1)'able -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message