From owner-cvs-all@FreeBSD.ORG Tue Oct 3 01:13:27 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4435D16A47B; Tue, 3 Oct 2006 01:13:27 +0000 (UTC) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17AB843D49; Tue, 3 Oct 2006 01:13:27 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k931DQwX049714; Tue, 3 Oct 2006 01:13:26 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k931DQl5049711; Tue, 3 Oct 2006 01:13:26 GMT (envelope-from iedowse) Message-Id: <200610030113.k931DQl5049711@repoman.freebsd.org> From: Ian Dowse Date: Tue, 3 Oct 2006 01:13:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb ehci.c ohci.c usb_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Oct 2006 01:13:27 -0000 iedowse 2006-10-03 01:13:26 UTC FreeBSD src repository Modified files: sys/dev/usb ehci.c ohci.c usb_subr.c Log: When changing the device address and max packet size in usbd_new_device(), close and re-open the default pipe instead of relying on the host controller driver to notice the changes. Remove the unreliable code that attempted to update these fields while the pipe was active. This fixes a case where the hardware could cache and continue to use the old address, resulting in a "getting first desc failed" error. PR: usb/103167 Revision Changes Path 1.50 +0 -11 src/sys/dev/usb/ehci.c 1.165 +0 -10 src/sys/dev/usb/ohci.c 1.87 +18 -0 src/sys/dev/usb/usb_subr.c