From owner-freebsd-bugs@FreeBSD.ORG Sat Aug 30 12:20:17 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AEACD16A4C0; Sat, 30 Aug 2003 12:20:17 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DB7043FD7; Sat, 30 Aug 2003 12:20:15 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7UJKEUp049956; Sat, 30 Aug 2003 12:20:14 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7UJKEOL049955; Sat, 30 Aug 2003 12:20:14 -0700 (PDT) Resent-Date: Sat, 30 Aug 2003 12:20:14 -0700 (PDT) Resent-Message-Id: <200308301920.h7UJKEOL049955@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Cc: ler@lerctr.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Larry Rosenman Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 157BB16A4BF for ; Sat, 30 Aug 2003 12:19:18 -0700 (PDT) Received: from lerlaptop.lerctr.org (lerlaptop.lerctr.org [207.158.72.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 118AF43FBD for ; Sat, 30 Aug 2003 12:19:15 -0700 (PDT) (envelope-from ler@lerlaptop.lerctr.org) Received: from lerlaptop.lerctr.org (localhost [127.0.0.1]) by lerlaptop.lerctr.org (8.12.9/8.12.9) with ESMTP id h7UJJEK9003611 for ; Sat, 30 Aug 2003 14:19:14 -0500 (CDT) (envelope-from ler@lerlaptop.lerctr.org) Received: (from ler@localhost) by lerlaptop.lerctr.org (8.12.9/8.12.9/Submit) id h7UJJElh003555; Sat, 30 Aug 2003 14:19:14 -0500 (CDT) Message-Id: <200308301919.h7UJJElh003555@lerlaptop.lerctr.org> Date: Sat, 30 Aug 2003 14:19:14 -0500 (CDT) From: Larry Rosenman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 X-GNATS-Notify: ler@lerctr.org Subject: misc/56206: src/sys/sys/cdefs.h uses PreProcessor variables that aren't defined, causing noisy warnings. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Larry Rosenman List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Aug 2003 19:20:17 -0000 >Number: 56206 >Category: misc >Synopsis: src/sys/sys/cdefs.h uses PreProcessor variables that aren't defined, causing noisy warnings. >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Aug 30 12:20:14 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Larry Rosenman >Release: FreeBSD 5.1-CURRENT i386 >Organization: LERCTR Consulting >Environment: System: FreeBSD lerlaptop.lerctr.org 5.1-CURRENT FreeBSD 5.1-CURRENT #42: Fri Aug 29 19:27:56 CDT 2003 ler@lerlaptop.lerctr.org:/usr/obj/usr/src/sys/LERLAPTOP i386 >Description: the /usr/include/sys/cdefs.h file uses __STD_C__ and _POSIX_C_SOURCE variables without them being defined. This causes noise that is unneeded. The following patch shuts it up, and is functionally equivalent. Can we get this applied? >How-To-Repeat: compile KDE and see all the warnings. >Fix: --- /usr/src/sys/sys/cdefs.h.orig Sun Jul 27 08:03:46 2003 +++ /usr/src/sys/sys/cdefs.h Sat Aug 30 14:11:09 2003 @@ -171,7 +171,7 @@ * software that is unaware of C99 keywords. */ #if !(__GNUC__ == 2 && __GNUC_MINOR__ == 95) -#if __STDC_VERSION__ < 199901 +#if defined(__STDC_VERSION__) && __STDC_VERSION__ < 199901 #define __restrict #else #define __restrict restrict @@ -323,13 +323,13 @@ */ /* Deal with IEEE Std. 1003.1-1990, in which _POSIX_C_SOURCE == 1. */ -#if _POSIX_C_SOURCE == 1 +#if defined(_POSIX_C_SOURCE) && _POSIX_C_SOURCE == 1 #undef _POSIX_C_SOURCE /* Probably illegal, but beyond caring now. */ #define _POSIX_C_SOURCE 199009 #endif /* Deal with IEEE Std. 1003.2-1992, in which _POSIX_C_SOURCE == 2. */ -#if _POSIX_C_SOURCE == 2 +#if defined(_POSIX_C_SOURCE) && _POSIX_C_SOURCE == 2 #undef _POSIX_C_SOURCE #define _POSIX_C_SOURCE 199209 #endif >Release-Note: >Audit-Trail: >Unformatted: