From owner-dev-commits-src-main@freebsd.org Fri Mar 12 10:02:10 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D9E7E5741AE for ; Fri, 12 Mar 2021 10:02:10 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "CN", Issuer "CN" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DxhDx493sz3L57; Fri, 12 Mar 2021 10:02:09 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [78.138.80.135]) by mx0.gentlemail.de (8.15.2/8.15.2) with ESMTP id 12CA1qdK012941; Fri, 12 Mar 2021 11:02:00 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id BC20AFCE; Fri, 12 Mar 2021 11:01:52 +0100 (CET) Subject: Re: git: 6e1d1bfcac77 - main - jail: Improve locking when removing prisons To: Jamie Gritton , dev-commits-src-main@FreeBSD.org References: <202102202242.11KMg79W017503@gitrepo.freebsd.org> From: Harry Schmalzbauer Organization: OmniLAN Message-ID: <0e8ca80f-cf62-4707-7cbd-dc0bbef061ed@omnilan.de> Date: Fri, 12 Mar 2021 11:01:52 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <202102202242.11KMg79W017503@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: inspected by milter-greylist-4.6.2 (mx0.gentlemail.de [78.138.80.130]); Fri, 12 Mar 2021 11:02:00 +0100 (CET) for IP:'78.138.80.135' DOMAIN:'mh0.gentlemail.de' HELO:'mh0.gentlemail.de' FROM:'freebsd@omnilan.de' RCPT:'' X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx0.gentlemail.de [78.138.80.130]); Fri, 12 Mar 2021 11:02:00 +0100 (CET) X-Rspamd-Queue-Id: 4DxhDx493sz3L57 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@omnilan.de designates 2a00:e10:2800::a130 as permitted sender) smtp.mailfrom=freebsd@omnilan.de X-Spamd-Result: default: False [-3.30 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[omnilan.de]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:e10:2800::a130:from]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[2a00:e10:2800::a130:from:127.0.2.255]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:61157, ipnet:2a00:e10:2800::/38, country:DE]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2021 10:02:11 -0000 Am 20.02.2021 um 23:42 schrieb Jamie Gritton: > The branch main has been updated by jamie: > > URL: https://cgit.FreeBSD.org/src/commit/?id=6e1d1bfcac77603541706807803a198c6d954d7c > > commit 6e1d1bfcac77603541706807803a198c6d954d7c > Author: Jamie Gritton > AuthorDate: 2021-02-20 22:38:58 +0000 > Commit: Jamie Gritton > CommitDate: 2021-02-20 22:38:58 +0000 > > jail: Improve locking when removing prisons > > Change the flow of prison_deref() so it doesn't let go of allprison_lock > until it's completely done using it (except for a possible drop as part > of an upgrade on its first try). > > Differential Revision: https://reviews.freebsd.org/D28458 > MFC after: 3 days > --- > sys/kern/kern_jail.c | 69 +++++++++++++++++++++++++++++++--------------------- > 1 file changed, 41 insertions(+), 28 deletions(-) Hello, do you still plan to MFC this?  It seems there's a bunch of locking related rework not MFC yet, but this one had the MFC tag in the commit log, so I guess it's a more important fix. Thanks! -harry