From owner-svn-src-all@FreeBSD.ORG Mon Jun 15 06:23:59 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6871106566B; Mon, 15 Jun 2009 06:23:59 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id 725908FC16; Mon, 15 Jun 2009 06:23:59 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 787961CC4E; Mon, 15 Jun 2009 08:23:58 +0200 (CEST) Date: Mon, 15 Jun 2009 08:23:58 +0200 From: Ed Schouten To: Bruce Evans Message-ID: <20090615062358.GR48776@hoeg.nl> References: <200906141801.n5EI1Zti056239@svn.freebsd.org> <4A356A0F.3050800@freebsd.org> <20090615075134.K24645@delplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="K9fR5eBdO1VxXkhU" Content-Disposition: inline In-Reply-To: <20090615075134.K24645@delplex.bde.org> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Sam Leffler , src-committers@FreeBSD.org Subject: Re: svn commit: r194204 - in head/sys: amd64/conf i386/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2009 06:24:00 -0000 --K9fR5eBdO1VxXkhU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Bruce, * Bruce Evans wrote: > I wouldn't use an implementation anything like FreeBSD's. printf()s > must be serialized, and once printf() is serialized there is no need > for buffering or cnputs().=20 Indeed. Just adding some synchronisation to printf() should also work and is in my opinion the best solution. printf() should only be called in exceptional cases, so taking the overhead of locking shouldn't really matter there. Unfortunately I am not planning on fixing this before the code freeze. PRINTF_BUFR_SIZE really isn't beautiful, but it should be good enough for now. To be continued. --=20 Ed Schouten WWW: http://80386.nl/ --K9fR5eBdO1VxXkhU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAko16P4ACgkQ52SDGA2eCwVFQgCfduWO9o0hgJISd7XSrfYCh1b2 lXUAmQGzM1nab41S4VadtCBlWt9caQ4D =dupT -----END PGP SIGNATURE----- --K9fR5eBdO1VxXkhU--