From owner-svn-src-head@freebsd.org Tue Mar 28 10:53:10 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 007FBD20D3C; Tue, 28 Mar 2017 10:53:10 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail108.syd.optusnet.com.au (mail108.syd.optusnet.com.au [211.29.132.59]) by mx1.freebsd.org (Postfix) with ESMTP id BF163AAE; Tue, 28 Mar 2017 10:53:09 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c122-106-153-191.carlnfd1.nsw.optusnet.com.au [122.106.153.191]) by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id 893181A2079; Tue, 28 Mar 2017 21:22:46 +1100 (AEDT) Date: Tue, 28 Mar 2017 21:22:46 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Ngie Cooper cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316081 - head/lib/libcam In-Reply-To: <201703280824.v2S8OGTb066055@repo.freebsd.org> Message-ID: <20170328205205.O1920@besplex.bde.org> References: <201703280824.v2S8OGTb066055@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=VbSHBBh9 c=1 sm=1 tr=0 a=Tj3pCpwHnMupdyZSltBt7Q==:117 a=Tj3pCpwHnMupdyZSltBt7Q==:17 a=kj9zAlcOel0A:10 a=-kYPNxOwzWyFIoaqOU8A:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 10:53:10 -0000 On Tue, 28 Mar 2017, Ngie Cooper wrote: > Log: > Use `sizeof(cam_errbuf)` instead of `CAM_ERRBUF_SIZE` in snprintf calls > > Reindent snprintf calls' arguments to match style(9) guidelines with > respect to indentation. Unfortunately, cam is is supposed to not match style(9) guidelines for indentation. It has its own style for many things, and used to follow this very consistently. Its style for continuation indentation is the same as gnu style (-lp). The following of -lp seems to have been perfect for multi-line snprintf()s in camlib.c. This gave 56 lines perfectly not matching style(9), or about 1/4 of the non-matches. Bruce