From owner-cvs-ports@FreeBSD.ORG  Wed Jul 15 05:30:48 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9BAE81065689;
	Wed, 15 Jul 2009 05:30:48 +0000 (UTC)
	(envelope-from pgollucci@p6m7g8.com)
Received: from exhub015-2.exch015.msoutlookonline.net
	(exhub015-2.exch015.msoutlookonline.net [207.5.72.94])
	by mx1.freebsd.org (Postfix) with ESMTP id 805638FC13;
	Wed, 15 Jul 2009 05:30:48 +0000 (UTC)
	(envelope-from pgollucci@p6m7g8.com)
Received: from philip.hq.rws (98.141.235.114) by smtpx15.msoutlookonline.net
	(207.5.72.103) with Microsoft SMTP Server (TLS) id 8.1.358.0;
	Tue, 14 Jul 2009 22:30:48 -0700
Message-ID: <4A5D6986.3050408@p6m7g8.com>
Date: Wed, 15 Jul 2009 01:30:46 -0400
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
Organization: P6M&7G8 Inc.
User-Agent: Thunderbird 2.0.0.22 (X11/20090709)
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <200907150509.n6F59kT1017951@repoman.freebsd.org>
	<4A5D68B6.5070702@FreeBSD.org>
In-Reply-To: <4A5D68B6.5070702@FreeBSD.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, "Philip M. Gollucci" <pgollucci@FreeBSD.org>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/sysutils/idled Makefile pkg-plist
 ports/sysutils/idled/files
 idled.in idled.sh patch-Makefile         patch-aa
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2009 05:30:49 -0000

Doug Barton wrote:
> Overall this is a big improvement, thanks. :) The only real error in
> the script is the empty _flags assignment which should be removed. You
> might also want to take a look at
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
> 
> hope this helps,

you know, it didn't actually occur to me to look at the contents of the 
rc script.

:)


-- 
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
Consultant          - P6M7G8 Inc.                http://p6m7g8.net
Senior Sys Admin    - RideCharge, Inc.           http://ridecharge.com
ASF Member          - Apache Software Foundation http://apache.org
FreeBSD Committer   - FreeBSD Foundation         http://freebsd.org

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.