Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 Nov 2011 00:01:52 +0300
From:      Sergey Kandaurov <pluknet@gmail.com>
To:        Anton Yuzhaninov <citrin@citrin.ru>, Andre Oppermann <andre@freebsd.org>
Cc:        svn-src-all@freebsd.org
Subject:   Re: svn commit: r226437 - head/sys/netinet
Message-ID:  <CAE-mSOJaff2as9DhyV4jsxR876pdJO1pPcx6xj7=dcN%2B5-vFYQ@mail.gmail.com>
In-Reply-To: <CAE-mSOKiNvh9rvHhEYB7N2%2BXcSezWZZtGe0sKdgwLaf4-mQxLA@mail.gmail.com>
References:  <201110161508.p9GF8hIc067651@svn.freebsd.org> <4EB1712C.9000309@citrin.ru> <CAE-mSOKiNvh9rvHhEYB7N2%2BXcSezWZZtGe0sKdgwLaf4-mQxLA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2 November 2011 21:40, Sergey Kandaurov <pluknet@gmail.com> wrote:
> On 2 November 2011 20:34, Anton Yuzhaninov <citrin@citrin.ru> wrote:
>> On 10/16/11 19:08, Andre Oppermann wrote:
>>>
>>> Author: andre
>>> Date: Sun Oct 16 15:08:43 2011
>>> New Revision: 226437
>>> URL: http://svn.freebsd.org/changeset/base/226437
>>>
>>> Log:
>>> =A0 VNET virtualize tcp_sendspace/tcp_recvspace and change the
>>> =A0 type to INT. =A0A long is not necessary as the TCP window is
>>> =A0 limited to 2**30. =A0A larger initial window isn't useful.
>>
>> In this commit sysctl renamed
>> from net.inet.tcp.sendspace to net.inet.tcp.tcp_sendspace
>> and from net.inet.tcp.recvspace to net.inet.tcp.tcp_recvspace
>>
>> This break POLA without any benefits.
>> Please revert sysctl rename.
>
> That was rather done accidentally as these names also match
> in-kernel variables which hold the corresponding sysctl values.

Please note, that I restored sysctl names for
tcp_sendspace/tcp_recvspace in svn r227034 revision.

--=20
wbr,
pluknet



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSOJaff2as9DhyV4jsxR876pdJO1pPcx6xj7=dcN%2B5-vFYQ>