From owner-cvs-all Wed Dec 6 13:58:29 2000 From owner-cvs-all@FreeBSD.ORG Wed Dec 6 13:58:25 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 79A7037B400; Wed, 6 Dec 2000 13:58:25 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id eB6LwPW09904; Wed, 6 Dec 2000 13:58:25 -0800 (PST) Date: Wed, 6 Dec 2000 13:58:25 -0800 From: Alfred Perlstein To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm phys_pager.c Message-ID: <20001206135824.G8051@fw.wintelcom.net> References: <200012062152.eB6LqNU01059@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200012062152.eB6LqNU01059@freefall.freebsd.org>; from alfred@FreeBSD.org on Wed, Dec 06, 2000 at 01:52:23PM -0800 Sender: bright@fw.wintelcom.net Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Alfred Perlstein [001206 13:52] wrote: > alfred 2000/12/06 13:52:23 PST > > Modified files: > sys/vm phys_pager.c > Log: > Really fix phys_pager: > > Backout the previous delta (rev 1.4), it didn't make any difference. > > If the requested handle is NULL then don't add it to the list of > objects, to be found by handle. > > The problem is that when asking for a NULL handle you are implying > you want a new object. Because objects with NULL handles were > being added to the list, any further requests for phys backed > objects with NULL handles would return a reference to the initial > NULL handle object after finding it on the list. > > Basically one couldn't have more than one phys backed object without > a handle in the entire system without this fix. If you did more > than one shared memory allocation using the phys pager it would > give you your initial allocation again. > > Revision Changes Path > 1.5 +37 -32 src/sys/vm/phys_pager.c > Matt Dillon reviewed this. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message