Date: Tue, 30 Jun 2015 21:43:49 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 201057] [PATCH] devel/jsoncpp: Properly version libjsoncpp.so. Message-ID: <bug-201057-13-6xZOyXk96c@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-201057-13@https.bugs.freebsd.org/bugzilla/> References: <bug-201057-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201057 --- Comment #3 from commit-hook@freebsd.org --- A commit references this bug: Author: rakuco Date: Tue Jun 30 21:43:06 UTC 2015 New revision: 391009 URL: https://svnweb.freebsd.org/changeset/ports/391009 Log: Properly version libjsoncpp.so. Fix the problem described in bug 200969: currently, libjsoncpp.so is not properly versioned by SCons; in other words, there's no SONAME in the library's ELF header, which confuses the linker when creating binaries that link against it. Solve it by using InstallVersionedLib(), available since SCons 2.3.0: this call is able to properly version the shared library the way we need it. Since there is no support for actually installing the files outside the build directory, we have to recreate the required symlinks ourselves in the Makefile. Another related change is that we now create the libraries with the proper names instead of doing that in the Makefile. I'm (ab)using the maintainer's approval given to bug 200939, as swills's latest patch includes this change as well. PR: 200969 PR: 201057 Approved by: johan@stromnet.se (maintainer) Changes: head/devel/jsoncpp/Makefile head/devel/jsoncpp/files/patch-SConstruct head/devel/jsoncpp/files/patch-src_lib__json_sconscript head/devel/jsoncpp/pkg-plist -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-201057-13-6xZOyXk96c>