From nobody Sun Jul 2 11:59:29 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qv6zj4TqXz4lZ55 for ; Sun, 2 Jul 2023 11:59:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qv6zj3WC5z4MqK for ; Sun, 2 Jul 2023 11:59:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688299169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hgg0iDEjCirOHCrgZDYaqTJ7p/QAWHr+eFMJfPbb+l0=; b=KlkCJxI1oZm2ApstlR0qidukdz/cNdvMgVIDAz6qN5n0RhJG7KORKDCJoAV6MDHts8V/qv hETUzAwifH+4CooCWiVBhcZm25SvxKpi2s7Kxc6mEXsA2zrZO9gMb00041U+Wq0JndDlhh g2ak3ctpscWuTLpQ8Hvn0SfSXy47nrK1QsypKcxzhONIZdeELZqDf5dRb5/+71y9HTI3Zu cFAxBFgj+jNUZAEP7G1ffP8x4BMChGHMKfM4ws5HsbodKwwaRbtV0MFfNyaa7UqYTTGUbp 1mcItSQXQBQyrS09E6ljAnh6nTnOKGD3oGdYvg1+Q7BYPUoH+yNleZ2ByoSy0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688299169; a=rsa-sha256; cv=none; b=QvF9oXJ7z8Wh03uI/VCixJ3cl5JxWj87LWrVHOkBsNhOhwE7EKpDwAoOAu7Enux0TCGyez mc3I8LlqEyeTt+P+E1u4LU8tqhAqFFQPfnN69be1oljqSANzcSV6ggTQOHpAkLKspX55T8 pbd/ZHLyeh9uKQVJULbEBOlKSFsCkqqMTlWhMkxYeNxTyJz6VTkYj5l99NgEnbdiWUt7Fe SJzf8wyjeT44nyGozK0pbFjRDRda3oluTppbbSS+hQYYox9FI9fZjuKjEFJljHBobZPPLZ QAcvxXI1aRHZxQ4InYBjIJ7oYUeQLNS8l4YS5O9+xpbrcKpiRuoZXAth9rvLaw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Qv6zj2QCLz16gx for ; Sun, 2 Jul 2023 11:59:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 362BxT6F037473 for ; Sun, 2 Jul 2023 11:59:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 362BxTWq037472 for net@FreeBSD.org; Sun, 2 Jul 2023 11:59:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 272319] FreeBSD kernel crash on MPD5 restart with PPP configuration. Date: Sun, 02 Jul 2023 11:59:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: afedorov@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272319 --- Comment #8 from Aleksandr Fedorov --- I think fix should look like this: diff --git a/sys/netgraph/ng_ksocket.c b/sys/netgraph/ng_ksocket.c index ba9845410e42..7074549ae403 100644 --- a/sys/netgraph/ng_ksocket.c +++ b/sys/netgraph/ng_ksocket.c @@ -936,12 +936,18 @@ ng_ksocket_shutdown(node_p node) /* Close our socket (if any) */ if (priv->so !=3D NULL) { - SOCKBUF_LOCK(&priv->so->so_rcv); - soupcall_clear(priv->so, SO_RCV); - SOCKBUF_UNLOCK(&priv->so->so_rcv); - SOCKBUF_LOCK(&priv->so->so_snd); - soupcall_clear(priv->so, SO_SND); - SOCKBUF_UNLOCK(&priv->so->so_snd); + /* + * SOLISTENNIG sockets doesn't have data upcalls. + */ + if (!SOLISTENING(priv->so)) { + SOCKBUF_LOCK(&priv->so->so_rcv); + soupcall_clear(priv->so, SO_RCV); + SOCKBUF_UNLOCK(&priv->so->so_rcv); + SOCKBUF_LOCK(&priv->so->so_snd); + soupcall_clear(priv->so, SO_SND); + SOCKBUF_UNLOCK(&priv->so->so_snd); + } + soclose(priv->so); priv->so =3D NULL; } --=20 You are receiving this mail because: You are the assignee for the bug.=