From owner-p4-projects@FreeBSD.ORG  Mon Dec  4 23:58:16 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 92CD216A4FB; Mon,  4 Dec 2006 23:58:16 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 505C316A40F;
	Mon,  4 Dec 2006 23:58:16 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9868143F83;
	Mon,  4 Dec 2006 23:50:11 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kB4NoQM4015055;
	Mon, 4 Dec 2006 16:50:27 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Mon, 04 Dec 2006 16:21:48 -0700 (MST)
Message-Id: <20061204.162148.-300783081.imp@bsdimp.com>
To: hselasky@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200612031915.kB3JFLbh077129@repoman.freebsd.org>
References: <200612031915.kB3JFLbh077129@repoman.freebsd.org>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Mon, 04 Dec 2006 16:50:27 -0700 (MST)
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 110969 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Dec 2006 23:58:16 -0000

In message: <200612031915.kB3JFLbh077129@repoman.freebsd.org>
            Hans Petter Selasky <hselasky@freebsd.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=110969
: 
: Change 110969 by hselasky@hselasky_mini_itx on 2006/12/03 19:14:41
: 
: 	Fix a bug in the uplcom probe routine where a revision of 0xFFFF
: 	was not treated as a special value. The old version of uplcom.c has
: 	the check, so probably a misunderstanding happened.
: 
: Affected files ...
: 
: .. //depot/projects/usb/src/sys/dev/usb/uplcom.c#14 edit
: 
: Differences ...
: 
: ==== //depot/projects/usb/src/sys/dev/usb/uplcom.c#14 (text+ko) ====
: 
: @@ -424,7 +424,8 @@
:  	    while(up->vendor) {
:  	        if ((up->vendor == uaa->vendor) &&
:  		    (up->product == uaa->product) &&
: -		    (up->release <= uaa->release)) {
: +		    ((up->release <= uaa->release) ||
: +		     (up->release == 0xFFFF))) {
:  		    return up;
:  		}
:  		up++;

What really needs to happen here is that we probe the plcom chip for
its properties, ala the linux driver rather than having a fixed (and
often wrong) table of hard codings.  I looked into this a while ago,
but got distracted...

Warner