From owner-freebsd-current  Mon Jul  3 09:11:13 1995
Return-Path: current-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id JAA11304
          for current-outgoing; Mon, 3 Jul 1995 09:11:13 -0700
Received: from mpp.com (mpp.Minn.Net [204.157.201.242])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id JAA11298
          for <current@freebsd.org>; Mon, 3 Jul 1995 09:11:11 -0700
Received: (from mpp@localhost) by mpp.com (8.6.11/8.6.9) id LAA00793; Mon, 3 Jul 1995 11:10:46 -0500
From: Mike Pritchard <mpp@legarto.minn.net>
Message-Id: <199507031610.LAA00793@mpp.com>
Subject: Re: spontaneous reboots ?
To: imb@scgt.oz.au (michael butler)
Date: Mon, 3 Jul 1995 11:10:45 -0500 (CDT)
Cc: current@freebsd.org
In-Reply-To: <199507031529.BAA02503@asstdc.scgt.oz.au> from "michael butler" at Jul 4, 95 01:29:13 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 897       
Sender: current-owner@freebsd.org
Precedence: bulk

I just filed a PR (with a patch) on this very problem just last
night.  It is PR kern/585.  I saw panics, and not spontaneous reboots.

> I wrote: 
> 
> > It's in the ipfw code .. 
> 
> In ip_fw.c at about line 300:
> 
> > bad_packet:
> >	if (f) {
> >			/*
> >			 * Do not ICMP reply to icmp
> >			 * packets....:)
> >			 */
> >		if (f_prt==IP_FW_F_ICMP)
> >			goto return_0;
> 
> *** NOTE "m" is still uninitialised here ***
> 
> >			/*
> >			 * Reply to packets rejected
> >			 * by entry with this flag
> >			 * set only.
> >			 */
> >		if (!(f->fw_flg&IP_FW_F_ICMPRPL))
> >			goto return_0;
> 
> *** and here ***
> 
> >		m = dtom(ip);
> 
>  : 
>  :
> 
> > return_0:
> >	m_freem(m);
> >	return 0;
> > good_packet:
> >	return 1;
> > }
> 
>  .. but we try m_freem(m) anyway ?
> 
> 	michael
-- 
Mike Pritchard
mpp@legarto.minn.net
"Go that way.  Really fast.  If something gets in your way, turn"