From owner-cvs-all Wed Jan 19 22:30:26 2000 Delivered-To: cvs-all@freebsd.org Received: from canonware.com (canonware.com [207.20.242.18]) by hub.freebsd.org (Postfix) with SMTP id EC0B715379 for ; Wed, 19 Jan 2000 22:30:23 -0800 (PST) (envelope-from jasone@canonware.com) Received: (qmail 44449 invoked by uid 1001); 20 Jan 2000 06:29:01 -0000 Date: Wed, 19 Jan 2000 22:29:01 -0800 From: Jason Evans To: Matthew Dillon Cc: Alfred Perlstein , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_aio.c Message-ID: <20000119222901.V27689@sturm.canonware.com> References: <200001200200.SAA61880@freefall.freebsd.org> <20000119210539.F20191@fw.wintelcom.net> <200001200626.WAA42307@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <200001200626.WAA42307@apollo.backplane.com>; from dillon@apollo.backplane.com on Wed, Jan 19, 2000 at 10:26:27PM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Wed, Jan 19, 2000 at 10:26:27PM -0800, Matthew Dillon wrote: > :* Jason Evans [000119 18:23] wrote: > :> jasone 2000/01/19 18:00:00 PST > :> > :> Modified files: > :> sys/kern vfs_aio.c > :> Log: > :> Don't tsleep() while at splbio(). > : > :Unless it fixes some other bug, sleeping with spl raised is perfectly valid. > > Not only that, but this change *introduces* a race condition. The > splx(s) CANNOT occur before the tsleep() or you have a race between > setting the KAIO_WAKEUP flag and an interrupt occuring just prior > to the tsleep(). > > Jason, please revert this change. tsleep()ing with the spl raised > is used all over the kernel for the precise reason that it was used > here: To prevent an interrupt/wakeup/tsleep race from occuring. Okay, will do. Thanks, Jason To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message