Date: Tue, 6 Mar 2018 00:57:56 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> To: Yuri Victorovich <yuri@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r463618 - head/sysutils/htop Message-ID: <CAMHz58RtMUiabvWuYDEEEJAw_Q9onriB%2BxcDR=ps1a7tqvQysA@mail.gmail.com> In-Reply-To: <201803050507.w2557uXT016687@repo.freebsd.org> References: <201803050507.w2557uXT016687@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 5, 2018 at 1:07 PM, Yuri Victorovich <yuri@freebsd.org> wrote: > Author: yuri > Date: Mon Mar 5 05:07:55 2018 > New Revision: 463618 > URL: https://svnweb.freebsd.org/changeset/ports/463618 > > Log: > sysutils/htop: Update to 2.1.0-26 > > Port changes: > * Changed to DISTVERSION > * Added to USES > Hi, Humm, what is added to USES? :) -USES= autoreconf libtool ncurses +USES= autoreconf libtool localbase ncurses pkgconfig python:2.7,build shebangfix scripts/MakeHeader.py is no-op in fact. It is used to generate header files but all header files are all ready in the tarball. I've run the script manually with python 3.6 and the generated header files are identical with the ones from the tarball. USES=shebangfix is also unnecessary because scripts/MakeHeader.py is unused. This port can be built without USES=localbase. As a result, this port can be simplified as follows: Index: Makefile =================================================================== --- Makefile (revision 463649) +++ Makefile (working copy) @@ -12,12 +12,11 @@ LICENSE= GPLv2 LICENSE_FILE= ${WRKSRC}/COPYING -USES= autoreconf libtool localbase ncurses pkgconfig python:2.7,build shebangfix +USES= autoreconf libtool ncurses pkgconfig GNU_CONFIGURE= yes CONFIGURE_ARGS= --enable-unicode USE_GITHUB= yes GH_ACCOUNT= hishamhm -SHEBANG_FILES= scripts/MakeHeader.py PLIST_FILES= bin/htop \ man/man1/htop.1.gz \ > * Added SHEBANG_FILES > * Removed LIBS (not needed) > * Replaced WWW with the https version > > Maintainer insisted on updating to the current version. > > PR: 225232 > Submitted by: Hung-Yi Chen <gaod@hychen.org> (maintainer) > Approved by: tcberner (mentor, implicit) > > Modified: > head/sysutils/htop/Makefile > head/sysutils/htop/distinfo > head/sysutils/htop/pkg-descr > > Modified: head/sysutils/htop/Makefile > ============================================================ > ================== > --- head/sysutils/htop/Makefile Mon Mar 5 03:33:06 2018 (r463617) > +++ head/sysutils/htop/Makefile Mon Mar 5 05:07:55 2018 (r463618) > @@ -2,7 +2,8 @@ > # $FreeBSD$ > > PORTNAME= htop > -PORTVERSION= 2.0.2 > +DISTVERSION= 2.1.0-26 > +DISTVERSIONSUFFIX= -g697f5bb > CATEGORIES= sysutils > > MAINTAINER= gaod@hychen.org > @@ -11,13 +12,13 @@ COMMENT= Better top(1) - interactive process viewer > LICENSE= GPLv2 > LICENSE_FILE= ${WRKSRC}/COPYING > > +USES= autoreconf libtool localbase ncurses pkgconfig > python:2.7,build shebangfix > GNU_CONFIGURE= yes > -LIBS+= -lexecinfo > - > CONFIGURE_ARGS= --enable-unicode > -USES= autoreconf libtool ncurses > USE_GITHUB= yes > GH_ACCOUNT= hishamhm > +SHEBANG_FILES= scripts/MakeHeader.py > + > PLIST_FILES= bin/htop \ > man/man1/htop.1.gz \ > share/applications/htop.desktop \ > > Modified: head/sysutils/htop/distinfo > ============================================================ > ================== > --- head/sysutils/htop/distinfo Mon Mar 5 03:33:06 2018 (r463617) > +++ head/sysutils/htop/distinfo Mon Mar 5 05:07:55 2018 (r463618) > @@ -1,3 +1,3 @@ > -TIMESTAMP = 1469166026 > -SHA256 (hishamhm-htop-2.0.2_GH0.tar.gz) = 1e93e6743dddad254fac2ad0d83b00 > a82173c75ecbd6ef6f7d55da690eb64b92 > -SIZE (hishamhm-htop-2.0.2_GH0.tar.gz) = 146391 > +TIMESTAMP = 1520223186 > +SHA256 (hishamhm-htop-2.1.0-26-g697f5bb_GH0.tar.gz) = > b1fc840b979a696eadb9723f3302792ae861f1725105b560971e01c2afa26eda > +SIZE (hishamhm-htop-2.1.0-26-g697f5bb_GH0.tar.gz) = 170183 > > Modified: head/sysutils/htop/pkg-descr > ============================================================ > ================== > --- head/sysutils/htop/pkg-descr Mon Mar 5 03:33:06 2018 > (r463617) > +++ head/sysutils/htop/pkg-descr Mon Mar 5 05:07:55 2018 > (r463618) > @@ -17,4 +17,4 @@ Comparison between 'htop' and 'top' > * In 'htop' you can kill multiple processes at once. > * 'top' is older, hence, more tested. > > -WWW: http://hisham.hm/htop/ > +WWW: https://hisham.hm/htop/ > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58RtMUiabvWuYDEEEJAw_Q9onriB%2BxcDR=ps1a7tqvQysA>