Date: Tue, 02 Aug 2022 12:43:32 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 265462] security/crowdsec: update to 1.4.1 Message-ID: <bug-265462-7788-fUHb7IHZaP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-265462-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-265462-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265462 --- Comment #4 from Nuno Teixeira <eduardo@FreeBSD.org> --- Created attachment 235632 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D235632&action= =3Dedit crowdsec-1.4.1 variables fixed v1 Sugestion: 1. switch to DISTVERSION --- PORTNAME=3D crowdsec -PORTVERSION=3D 1.3.4 # NOTE: change BUILD_VERSION and BUILD_TAG as well -PORTREVISION=3D 2 DISTVERSIONPREFIX=3D v +DISTVERSION=3D 1.4.1 # NOTE: change _BUILD_TAG as well CATEGORIES=3D security --- 2. remove #GH_TAGNAME comment add user varialble _BUILD_TAG (short hash) --- -GH_TAGNAME=3D v1.3.4-freebsd -#GH_TAGNAME is automatically set from DISTVERSION +GH_TAGNAME=3D v1.4.1-freebsd +_BUILD_TAG=3D 527995f --- 3. substitute BUILD_VERSION variable substitute BUILD_VERSION variable --- -MAKE_ENV=3D BUILD_VERSION=3D"v1.3.4" \ - BUILD_TAG=3D"c196ed45b62c12d9c6549da927c37c64bd08c642" \ +MAKE_ENV=3D BUILD_VERSION=3D"${DISTVERSIONFULL}" \ + BUILD_TAG=3D"${_BUILD_TAG}" \ --- Question: since GH_TAGNAME could be a hash of a commit id to do a snapshot,= in this example a commit id, why it is needed to mention hash in BUILD_TAG? IMO, BUILD_TAG=3D${GH_TAGNAME} will be sufficient Could you test it? Cheers --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-265462-7788-fUHb7IHZaP>