From owner-cvs-all Wed Oct 24 2:17:45 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id C4DD137B401; Wed, 24 Oct 2001 02:17:27 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id f9O9HIg14697; Wed, 24 Oct 2001 12:17:18 +0300 (EEST) (envelope-from ru) Date: Wed, 24 Oct 2001 12:17:18 +0300 From: Ruslan Ermilov To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/examples Makefile Message-ID: <20011024121718.D92032@sunbay.com> References: <200110240759.f9O7xgU25812@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200110240759.f9O7xgU25812@freefall.freebsd.org>; from markm@FreeBSD.org on Wed, Oct 24, 2001 at 12:59:42AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Oct 24, 2001 at 12:59:42AM -0700, Mark Murray wrote: > markm 2001/10/24 00:59:42 PDT > > Modified files: > share/examples Makefile > Log: > Back out my last commit. Ruslan (ru) has a better fix. > > Revision Changes Path > 1.33 +0 -4 src/share/examples/Makefile > This log is not quite correct. I don't have a fix to commit, and the real "fix" is to just clean up the stale objdir for src/share/examples, if it exists (it's not created anymore after src/share/examples/ipfilter/Makefile,v 1.2 commit, so the time frame for possibly affected users is between 10/20 and 10/22), but the actual problem was that your commit didn't fix anything but just hided the real problem if that stale objdir existed. We can consider putting this little script cleaning up the stale share/examples .OBJDIR into UPDATING, if the number of affected people will grow. Alternatively, we can back out the backout of revision 1.30 in revision 1.31 of src/share/examples/Makefile :-) but that is against Makefile style (yet to be written), as in NOOBJ-hinted Makefiles it should be safe to assume that .CURDIR == .OBJDIR. That is to say, from all 19 NOOBJ-hinted src/ Makefiles, only gnu/include/Makefile used ${.CURDIR}; I am saying "used" because I have just fixed that in revision 1.9. :-) Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message