From nobody Mon Mar 27 08:17:38 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PlQfV6phPz41xBP for ; Mon, 27 Mar 2023 08:17:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PlQfV5QkBz4F3S for ; Mon, 27 Mar 2023 08:17:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679905058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O6LoSPzZj55cSMvE7ogOfHgLYaVW+llct7k6SnmpIes=; b=gW0I3KAI+QwXUj0GhB2+laMFbyIR1cK8KQA51cJfA72jks+9lvop4FgEyGbNraycFhP76/ M5Vt/0Qxvm+JXPaqmm/nSjH1HQ5TOXUTBKrB3DBCWfg6eN3ITq7pPnbs5got8/WOEb2P1r HYu8EwmkRQ8CO8speeM6hdriPbY2SRZRso+dbHKlTwagJc6Yn8J3yoyPhITsn4nRsxuuu+ 63HRdp+ghO3lx17mVYESlxKOA+ZGlDuTEUJvm7x9QvAIbG+xHCxjwojfvZrRMNTo4KXOmC huGauugOZZIxCczYIBCYBTb7xlTSaIG6WMepJAQWNR33u2GYZlkMrHr7s/lgxg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679905058; a=rsa-sha256; cv=none; b=RDoXjsqcLbo3bVow2RKVWxdaomo+4f1rOvL+CGqOwHra56BCI8rMPsFFkJfP6U42pNTYmt KtN5wOhyo4W2d+hm8/jUZAYdAUQ+C2SFjlefQzY1edsqNHkv/G3QWx2h4kMFgBZXxQefI1 I2Ny5TyGN7//tiBvXjt7FR0mNskP/nCLo5+IhjEuoNrc5SvHtYctk/ss22EFVPIyCZBAoG mXRVbQ1Oa6QaOyZVlTsErsBko1ggPWC31ivJ0OSlaIZ2x7HMfa6a/yQ4SNEEcP089HmXjU gp5uORfd7V/Bt72A5xt/9RJEFz1QgQlB4K+bppBbKXSl2klZ1eCGPIzyKgJ5Aw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PlQfV4Q9szFNc for ; Mon, 27 Mar 2023 08:17:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32R8HcvT017269 for ; Mon, 27 Mar 2023 08:17:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32R8Hcta017268 for net@FreeBSD.org; Mon, 27 Mar 2023 08:17:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268246] crash and panic using pfsync on 13.1-RELEASE Date: Mon, 27 Mar 2023 08:17:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268246 --- Comment #101 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D1d6ece4351a01179e3a5ebbdb3fa2e605= 3a2d7aa commit 1d6ece4351a01179e3a5ebbdb3fa2e6053a2d7aa Author: Kristof Provost AuthorDate: 2023-03-20 13:26:33 +0000 Commit: Kristof Provost CommitDate: 2023-03-27 00:28:37 +0000 pfsync: add missing unlock in pfsync_defer_tmo() The callout for pfsync_defer_tmo() is created with CALLOUT_RETURNUNLOCKED, because while the callout framework takes care of taking the lock we want to run a few operations outside of the lock, so we unlock ourselves. However, if `sc->sc_sync_if =3D=3D NULL` we return without releasing the lock, and leak the lock, causing later deadlocks. Ensure we always release the bucket lock when we exit pfsync_defer_tmo() PR: 268246 MFC after: 1 week Sponsored by: Rubicon Communications, LLC (Netgate) (cherry picked from commit 844ad2828a35c434b893af4274b1f6c50332dd70) sys/netpfil/pf/if_pfsync.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=