From owner-svn-src-head@freebsd.org Sun Feb 23 20:21:46 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A941924778E for ; Sun, 23 Feb 2020 20:21:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Qc6d533Yz3HFw for ; Sun, 23 Feb 2020 20:21:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf41.google.com with SMTP id o18so3328135qvf.1 for ; Sun, 23 Feb 2020 12:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V7X8tk9+glRuaiYvdosrcbHE3jpy5Sm42FBrF7XJe70=; b=HXQwCu2IML9YgcOQaqLh7VGTLmUL1JY11PCRGGuSFvMh5nuiUyMXNA1fse8owSpqwZ I72vupcxHl+SO0949OMQfBbBlvTsl9+UAdgorrBcLZl65PeqQXvixg8izlpxSU43/7q6 5mLgIEWZo/cmqKmidSDyU95egUcuPk1eVyR+bziprG5uf07CAGz7upMOjrQjDp++BQS0 RU/RzKG34ZVM7HEvBwCP5u4jErgvddwyombpxLixAw6bp+sYlha5b2qUFllSfhUfY5E2 eer2SqjJHDZVwUnVotlSbOlbLwjO2tIu8iEJpA/LVPjdoLy8DqrxA75cEO4notczfNzW xbVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V7X8tk9+glRuaiYvdosrcbHE3jpy5Sm42FBrF7XJe70=; b=obRYHFrL8uUYlVYENPeVnD5/B3mD65pc3jOc6fxxYDY+j01ukIyxablxOWiz32FDAV gIPNZESFhzbLw3KJCFcoY9GrqyQLp3MJ/Dsg7iqncoftzRUA8Zq/skUBvj+SzTjviOrJ ESXzOtPGzc3XsGqCPblBZWwGC8l9xUmPqa4GhhddlTPG/NCt2y3h3Wl+9ZGS8fr2ZoNu c293SFIAPhK9gspY/MeWQqCX1RxH5o3P0QwlUhoViFEYEwejfl6g6PeaO5yEM36MDK15 7LUe7Smy3o/M2d09tB/DKIDjqHT8GEnqxK1NmeVWnrVHt7NLSKDyHVVFAkpWK1z7X8Lp MF5g== X-Gm-Message-State: APjAAAXNpFlWw+eZRFMT2d/b7msCCBj0aGIdd3yoYOe+P5lcGgKiKeTg HNGhyq6ZBlaaAsJqMFr9vsrvxnJmxKkgLesIQxx/0g== X-Google-Smtp-Source: APXvYqyCHpfUu4V3uCrk+UQBg6lO87qcPL16g9uajgKP4dY8ZpIvdRoOJcSoHuG5CCLi+pzDe4rAzGiij5uA9gFlZ0E= X-Received: by 2002:a05:6214:1433:: with SMTP id o19mr41632430qvx.87.1582489304672; Sun, 23 Feb 2020 12:21:44 -0800 (PST) MIME-Version: 1.0 References: <202002231904.01NJ4FmD046982@repo.freebsd.org> <66fe6ff74daea4320dc1c89ca36dbad964945081.camel@freebsd.org> In-Reply-To: <66fe6ff74daea4320dc1c89ca36dbad964945081.camel@freebsd.org> From: Warner Losh Date: Sun, 23 Feb 2020 13:21:32 -0700 Message-ID: Subject: Re: svn commit: r358262 - head/sys/conf To: Ian Lepore Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 48Qc6d533Yz3HFw X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=HXQwCu2I; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f41) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.62 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-0.63)[ip: (0.48), ipnet: 2607:f8b0::/32(-1.88), asn: 15169(-1.67), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Feb 2020 20:21:46 -0000 On Sun, Feb 23, 2020, 12:37 PM Ian Lepore wrote: > On Sun, 2020-02-23 at 19:04 +0000, Warner Losh wrote: > > Author: imp > > Date: Sun Feb 23 19:04:15 2020 > > New Revision: 358262 > > URL: https://svnweb.freebsd.org/changeset/base/358262 > > > > Log: > > Use MACHINE_ARCH instead of TARGET_ARCH > > > > TARGET_ARCH is only for use in Makefile.inc1 contexts. MACHINE_ARCH is > the > > preferred thing to set. Makefile.inc1 sets MACHINE_ARCH in the cross > build > > case, and make sets it in the native build case. This will fix anybody > doing a > > native build. Add a comment for why we have to do this dance so > when/if the > > problem with CFLAGS is fixed for the kernel this workaround can be > removed. > > > > I suddenly wonder: why does the kernel build need to know about the > float ABI if we don't use floating point in the kernel? If it's about > whether to include support for the floating point hardware > (save/restore context at the userland boundary, etc), then shouldn't > that be controlled with a kernel config option or device statement like > it is on other arches? > This is so the sysctl that make uses returns the right thing. If the kernel actually is being compiled with different -march= to > generate hardfloat instructions/register usage/etc, then shouldn't > there be some compiler-defined macro to indicate that? (A quick search > says that __riscv_float_abi_soft may be that macro.) > The code review for the prior change explored that. This change just documented the prior change and used the right make variable. I honestly think this is a short term hack until other issues are settled. I justed wanted the hack to be right. Warner -- Ian > > >