From nobody Sat Apr 23 01:36:27 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D970C1A8055A for ; Sat, 23 Apr 2022 01:36:32 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KlYlh25QQz3p34; Sat, 23 Apr 2022 01:36:32 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:3c04:dbac:3dcb:cb4d]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 4E963721E2808; Sat, 23 Apr 2022 03:36:28 +0200 (CEST) Content-Type: text/plain; charset=us-ascii List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: IPv6 TCP: first two SYN packets to local v6 unicast addresses ignored From: tuexen@freebsd.org In-Reply-To: Date: Sat, 23 Apr 2022 03:36:27 +0200 Cc: Florian Smeets , Michael Butler , freebsd-current@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <592A0A46-C703-4F93-9F43-5D167469A921@freebsd.org> References: <131c363a-7b7d-a106-5b8a-6838e7a66567@smeets.xyz> <9679642b-5de6-28be-a64b-07375c3efeba@smeets.xyz> <7cd2e76a-c6d1-e8d7-b9fb-b8797f1ca731@smeets.xyz> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4KlYlh25QQz3p34 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 193.175.24.27 is neither permitted nor denied by domain of tuexen@freebsd.org) smtp.mailfrom=tuexen@freebsd.org X-Spamd-Result: default: False [-2.58 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEFALL_USER(0.00)[tuexen]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-0.98)[-0.981]; R_SPF_SOFTFAIL(0.00)[~all:c]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.961]; FROM_NO_DN(0.00)[]; NEURAL_HAM_MEDIUM(-0.94)[-0.942]; MLMMJ_DEST(0.00)[freebsd-current]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[193.175.24.27:from] X-ThisMailContainsUnwantedMimeParts: N > On 23. Apr 2022, at 01:38, Gleb Smirnoff wrote: > > Hi Florian, > > here is a patch that should help with the IPv6 problem. I'm not > yet committing it, it might be not final. Hi Gleb, when I was looking at the code, I was also wondering if it would make more sense to check for M_LOOP. However, isn't the rcvif wrong for the first two received packets? I would expect it always to be the loopback interface. Is that expectation wrong? I also have an additional question: Why is this check protected by an (ia != NULL) condition? It does not make any use of ia? Best regards Michael > -- > Gleb Smirnoff >