From owner-freebsd-current@FreeBSD.ORG Fri Aug 27 20:31:56 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4FB3A1065693 for ; Fri, 27 Aug 2010 20:31:56 +0000 (UTC) (envelope-from sullrich@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 18D618FC08 for ; Fri, 27 Aug 2010 20:31:55 +0000 (UTC) Received: by iwn36 with SMTP id 36so3279257iwn.13 for ; Fri, 27 Aug 2010 13:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=y9/y8wQshMO/fsLN5vje5fkSukJUzKocdVmZ2Bs2ns0=; b=KjHK4ypjrb1Fm2fwViO22BTWuc6b57JQWIjW7Yw0Jf6STN6r/PA03JNCHdad6+Wk9L peNfbkJ2VnPfF5+b1/wTp6U0W+VjufbpGKI0C7XjwHQ0SIEsOCb3CzE9Ys2YtolXLVTy LGCR8NBRg/z7KfsZ2X3TiX+qlr8WZCQ82tiqM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=I2kgGfQfU7PiN+33J1UL5DjCNcKbxG9yCjmeR6V2FLjKHzBXm84oxxxCBoKpmSV5j9 LTLNWoVvsimJfQEIXk4Jrg9kVPvqCkyYgeBSVu/QtWiOrXR/jWWHN46WPQNrbhgfBXcv 5HQDqG0/pXQ0Nsei4lQ8J3QljNbQLjlFls9Rs= Received: by 10.231.11.71 with SMTP id s7mr1611277ibs.85.1282939613526; Fri, 27 Aug 2010 13:06:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.148.10 with HTTP; Fri, 27 Aug 2010 13:06:33 -0700 (PDT) In-Reply-To: <4C739C55.3020800@FreeBSD.org> References: <4C739C55.3020800@FreeBSD.org> From: Scott Ullrich Date: Fri, 27 Aug 2010 16:06:33 -0400 Message-ID: To: Martin Matuska Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org Subject: Re: [CFT] ZFS ACL and rrwlock speedup X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2010 20:31:56 -0000 2010/8/24 Martin Matuska : > Dear FreeBSD community, > > in my last CFT I presented a patch that improves ZFS write speed. There > have been easily portable improvements on the read side in OpenSolaris, > too. Of course, the improvement here is by far not that dramatic as in > the zfs_metaslab.patch, but OpenSolaris developers claim this also > improves the speed of stat() calls. > > I would like to Call For Testing for the following patch (9-CURRENT): > http://people.freebsd.org/~mm/patches/zfs/zfs_abe_stat_rrwlock.patch > > This patch adds the following: > - better ACL caching and speedup of the ACL permission checks > - lowered mutex contention in the read/writer lock (rrwlock) > - several bugfixes > > This patch does not interfere with the zfs_metaslab.patch > > To apply the patch against 8-STABLE, you need to apply the v15 update first: > http://people.freebsd.org/~mm/patches/zfs/v15/stable-8-v15.patch > > The patch imports the following OpenSolaris onnv revisions: > 9749 (without zlook), 9866, 9981, 10143, 10232, 10295, 10250, 10269 > > And covers the following OpenSolaris Bug IDs: > 6802734 Support for Access Based Enumeration (not used on FreeBSD) > 6844861 inconsistent xattr readdir behavior with too-small buffer > 6848431 zfs with rstchown=0 or file_chown_self privilege allows user to > "take" ownership > 6775100 stat() performance on files on zfs should be improved > 6827779 rrwlock is overly protective of its counters > 6857433 memory leaks found at: zfs_acl_alloc/zfs_acl_node_alloc > 6860318 truncate() on zfsroot succeeds when file has a component of its > path set without access permission > 6865875 zfs sometimes incorrectly giving search access to a dir > 6870564 panic in zfs_getsecattr > 6867395 zpool_upgrade_007_pos testcase panic'd with BAD TRAP: type=e > (#pf Page fault) > 6868276 zfs_rezget() can be hazardous when znode has a cached ACL So far so good on this patch as well. Running it for a good 3 days with 4TB and it is nice and fast (220MB/sec for 1.5 TB drives). Scott