From owner-freebsd-current@FreeBSD.ORG  Fri Mar 12 10:36:29 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19FC4106564A
	for <freebsd-current@freebsd.org>; Fri, 12 Mar 2010 10:36:29 +0000 (UTC)
	(envelope-from gary.jennejohn@freenet.de)
Received: from mout1.freenet.de (mout1.freenet.de [IPv6:2001:748:100:40::2:3])
	by mx1.freebsd.org (Postfix) with ESMTP id A56B58FC13
	for <freebsd-current@freebsd.org>; Fri, 12 Mar 2010 10:36:28 +0000 (UTC)
Received: from [195.4.92.15] (helo=5.mx.freenet.de)
	by mout1.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port
	25) (Exim 4.72 #1)
	id 1Nq2EE-0002uv-KX; Fri, 12 Mar 2010 11:36:27 +0100
Received: from p57ae0ed7.dip0.t-ipconnect.de ([87.174.14.215]:29747
	helo=ernst.jennejohn.org)
	by 5.mx.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port 25)
	(Exim 4.72 #2) id 1Nq2ED-0005eI-Gw; Fri, 12 Mar 2010 11:36:25 +0100
Date: Fri, 12 Mar 2010 11:36:25 +0100
From: Gary Jennejohn <gary.jennejohn@freenet.de>
To: Garrett Cooper <yanefbsd@gmail.com>
Message-ID: <20100312113625.1b2b017f@ernst.jennejohn.org>
In-Reply-To: <7d6fde3d1003112024o646afbf2w1ee4d81abae7e608@mail.gmail.com>
References: <4B991C00.3010809@intertainservices.com>
	<790a9fff1003111714s58d9ee4bl6454d1d52bf705b8@mail.gmail.com>
	<7d6fde3d1003111720g7dccf93w1f51db88758a5c4d@mail.gmail.com>
	<20100311.192423.683591382013853731.imp@bsdimp.com>
	<7d6fde3d1003112024o646afbf2w1ee4d81abae7e608@mail.gmail.com>
X-Mailer: Claws Mail 3.7.4 (GTK+ 2.16.2; amd64-portbld-freebsd9.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org
Subject: Re: HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: gary.jennejohn@freenet.de
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Mar 2010 10:36:29 -0000

On Thu, 11 Mar 2010 20:24:57 -0800
Garrett Cooper <yanefbsd@gmail.com> wrote:

>     I can haz PR review then? Here's an easy one :)...
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=144644
> 

Looks OK to me except I don't like the
	if (something) {
		one-line-of-code();
	}
constructs, but according to style(9) these are sort-of OK, viz

     Closing and opening braces go on the same line as the else.  Braces that
     are not necessary may be left out.
                       ^^^^^^^^^^^^^^^
             if (test)
                     stmt;
             else if (bar) {
                     stmt;
                     stmt;
             } else
                     stmt;

Saved by the "may."

---
Gary Jennejohn (gj@)