From owner-svn-src-head@FreeBSD.ORG Tue Apr 7 15:16:11 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1452BFD9; Tue, 7 Apr 2015 15:16:11 +0000 (UTC) Received: from mail-n.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail-n.franken.de", Issuer "Thawte DV SSL CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 97FD81F5; Tue, 7 Apr 2015 15:16:10 +0000 (UTC) Received: from [192.168.1.200] (p508F1706.dip0.t-ipconnect.de [80.143.23.6]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTP id A36EA1C1622D4; Tue, 7 Apr 2015 17:16:06 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r281198 - in head/sys/netgraph/bluetooth: hci include l2cap socket From: Michael Tuexen In-Reply-To: Date: Tue, 7 Apr 2015 17:16:04 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201504071022.t37AMvts041485@svn.freebsd.org> To: "Bjoern A. Zeeb" X-Mailer: Apple Mail (2.2070.6) Cc: svn-src-head@freebsd.org, Takanori Watanabe , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2015 15:16:11 -0000 > On 07 Apr 2015, at 13:36, Bjoern A. Zeeb wrote: >=20 >=20 >> On 07 Apr 2015, at 10:22 , Takanori Watanabe = wrote: >>=20 >> Author: takawata >> Date: Tue Apr 7 10:22:56 2015 >> New Revision: 281198 >> URL: https://svnweb.freebsd.org/changeset/base/281198 >>=20 >> Log: >> Initial Bluetooth LE support. >>=20 >> Note that sockaddr_l2cap structure is changed , check socket address >> to initialize new structure member and define L2CAP_SOCKET_CHECKED >> before including ng_btsocket.h >>=20 >> Differential Revision: https://reviews.freebsd.org/D2021 >> Reviewed by:emax >>=20 >=20 >=20 > I see a lot of: >=20 > = /scratch/tmp/bz/head.svn/lib/libbluetooth/../../sys/netgraph/bluetooth/inc= lude/ng_btsocket.h:246:2: error: #warning "Make sure new member of = socket address initialized" I also do see at least two instances of it breaking the compilation: --- all_subdir_libbluetooth --- --- bluetooth.So --- In file included from = /usr/home/tuexen/head/lib/libbluetooth/bluetooth.c:34: In file included from = /usr/home/tuexen/head/lib/libbluetooth/bluetooth.h:49: = /usr/home/tuexen/head/lib/libbluetooth/../../sys/netgraph/bluetooth/includ= e/ng_btsocket.h:246:2: error: "Make sure new member of socket address = initialized" [-Werror,-W#warnings] #warning "Make sure new member of socket address initialized" ^ 1 error generated. --- dev.So --- In file included from /usr/home/tuexen/head/lib/libbluetooth/dev.c:33: In file included from = /usr/home/tuexen/head/lib/libbluetooth/bluetooth.h:49: = /usr/home/tuexen/head/lib/libbluetooth/../../sys/netgraph/bluetooth/includ= e/ng_btsocket.h:246:2: error: "Make sure new member of socket address = initialized" [-Werror,-W#warnings] #warning "Make sure new member of socket address initialized" ^ 1 error generated. --- bluetooth.So --- *** [bluetooth.So] Error code 1 make[5]: stopped in /usr/home/tuexen/head/lib/libbluetooth Best regards Michael >=20 > when trying to build kernels. Is this expected? >=20 >=20 >> Modified: >> head/sys/netgraph/bluetooth/hci/ng_hci_cmds.c >> head/sys/netgraph/bluetooth/hci/ng_hci_evnt.c >> head/sys/netgraph/bluetooth/hci/ng_hci_main.c >> head/sys/netgraph/bluetooth/hci/ng_hci_misc.c >> head/sys/netgraph/bluetooth/hci/ng_hci_misc.h >> head/sys/netgraph/bluetooth/hci/ng_hci_ulpi.c >> head/sys/netgraph/bluetooth/hci/ng_hci_var.h >> head/sys/netgraph/bluetooth/include/ng_btsocket.h >> head/sys/netgraph/bluetooth/include/ng_btsocket_l2cap.h >> head/sys/netgraph/bluetooth/include/ng_hci.h >> head/sys/netgraph/bluetooth/include/ng_l2cap.h >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_cmds.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_cmds.h >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_evnt.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_llpi.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_llpi.h >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_misc.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_misc.h >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_ulpi.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_var.h >> head/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c >> head/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c >> head/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap_raw.c >=20 > =E2=80=94=20 > Bjoern A. Zeeb Charles Haddon = Spurgeon: > "Friendship is one of the sweetest joys of life. Many might have = failed > beneath the bitterness of their trial had they not found a friend." >=20 >=20 >=20