From owner-dev-commits-src-all@freebsd.org Tue Aug 3 16:31:26 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8175763BE57 for ; Tue, 3 Aug 2021 16:31:26 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GfL3f17vJz3GQn for ; Tue, 3 Aug 2021 16:31:26 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1628008280; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=XOW4hnTVIWv//TWUlaWXPqGQkNjSTxkJ3T+11oqf4ISF9/TFOp8kOcydg48ZkBmV47QF2Q71YwA+I X0qsf0YRlfVQix7Ve+tAUAdRTNOwUdPz24a4/sVHd2HUOUeHq3yH4WHYVRVo6a+d2dElh9GqPIM+Y5 J2jMAAn7kqWc1CzX1Hb8wvtbOVvY4/s3HnQX5yDglGa9w4SKfqokuzz1IKEETCnNe9JnCtKJryDwoo 0TYMc/WsOPdjCeiSmMQjxBcrveNKco6uRy8ji7L+0yNw1cvBecdfU4WUhSUD7RGA9DELbeOo6f/A+6 xxNpaYGqQGX9UDs0nD9QPM9KYhegNaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=oZ0OR14MSJYFlI9Hqn22WatJdqhATMzFbJwOBgbrOYI=; b=TcD6wwYBx+ubqmDCb+JAIml076/VB1OWofMOVvbD+zBT+y+rf7579G3ciVoJtpYh4ZdPOZ7prDHIt Utz+RGZ5NVwGMg0CB68ZozGja1Ds3Q228o/bYqpXnkwYAD8yp19On8qeyjIR+GFUWtSS8fR7OI5Zi6 PhsC8at/CB5ydFtT6O+CUPj3dL/OSP9SP7O1u7+T8rFG43OF2eB8/LNJhuaOTXKnama/XforhQn5QA 1IXz5bEg/LUDWQEWX/JzNNi7lblwcuHzkFIBqPXyGjCqe+g7+r4mavCy5XnaLZdgwCaZC+jsrTDv2p qNcWWtQ6E/hqGfJWP2vITfRBLl+e36g== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=oZ0OR14MSJYFlI9Hqn22WatJdqhATMzFbJwOBgbrOYI=; b=RPVrODoz9jUueiilbgf13uHFbsAP/KJniYDr1BtBwS6HmVkx6X8iIEL9TDJs/eOZikPcU0wLJkmcC 4fKVmFTG3Bb1IGJQ3TYhmQ3kqVd0vi5rYI3kYVH/q2n3Nea2vHnAgy2iF7fiLfZtIJrtIQvIuvOcwl e0G4p6IX0zrFUr2BFR/cJwa5T6kMtkGSfsgscFhsuf/7FTrqoCCa81tpqWkEnWFZSmzS1NqqNRnuhp boP9ZdfBJu9kEWlKGC3rhU62R/+rC2tYHQNuFU3Fo8r4vMq3daCAU4GJTMwS0WbHle0tD8jaRAJrJe Y7AFBs40WtIAtwHwdWtk5ELuxJ6DhCg== X-Originating-IP: 67.177.211.60 X-MHO-RoutePath: aGlwcGll X-MHO-User: 3aa508c1-f478-11eb-a657-89389772cfc7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 3aa508c1-f478-11eb-a657-89389772cfc7; Tue, 03 Aug 2021 16:31:18 +0000 (UTC) Received: from [172.22.42.84] (rev2.hippie.lan [172.22.42.84]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 173GVHYs076666; Tue, 3 Aug 2021 10:31:17 -0600 (MDT) (envelope-from ian@freebsd.org) X-Authentication-Warning: paranoia.hippie.lan: Host rev2.hippie.lan [172.22.42.84] claimed to be [172.22.42.84] Message-ID: Subject: Re: git: dfcaa2c18bf9 - main - enetc_mdio: Support building the driver as a loadable module. From: Ian Lepore To: Marcin Wojtas , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Date: Tue, 03 Aug 2021 10:31:17 -0600 In-Reply-To: <202108031008.173A84BG096694@gitrepo.freebsd.org> References: <202108031008.173A84BG096694@gitrepo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.3 FreeBSD GNOME Team MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4GfL3f17vJz3GQn X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2021 16:31:26 -0000 On Tue, 2021-08-03 at 10:08 +0000, Marcin Wojtas wrote: > The branch main has been updated by mw: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=dfcaa2c18bf9c69b94d531364f8913b23f19505f > > commit dfcaa2c18bf9c69b94d531364f8913b23f19505f > Author:     Kornel Duleba > AuthorDate: 2021-07-28 11:38:53 +0000 > Commit:     Marcin Wojtas > CommitDate: 2021-08-03 10:07:49 +0000 > >     enetc_mdio: Support building the driver as a loadable module. >     > [...] > diff --git a/sys/modules/enetc_mdio/Makefile > b/sys/modules/enetc_mdio/Makefile > new file mode 100644 > index 000000000000..f448fc526705 > --- /dev/null > +++ b/sys/modules/enetc_mdio/Makefile > @@ -0,0 +1,8 @@ > +#$FreeBSD$ > + > +.PATH: ${SRCTOP}/sys/dev/enetc > + > +KMOD   = enetc_mdio > +SRCS   = enetc_mdio_pci.c enetc_mdio.c > + > +.include A module makefile must list all the header files it uses which are generated at build time from interface definitions (.m files) in its SRCS list. For this driver, I think that means ifdi_if.h and miibus_if.h. -- Ian