From owner-freebsd-numerics@freebsd.org Wed Nov 8 11:00:45 2017 Return-Path: Delivered-To: freebsd-numerics@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9316EE4EF75 for ; Wed, 8 Nov 2017 11:00:45 +0000 (UTC) (envelope-from dimpase@gmail.com) Received: from mail-lf0-x22a.google.com (mail-lf0-x22a.google.com [IPv6:2a00:1450:4010:c07::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1259374CC6 for ; Wed, 8 Nov 2017 11:00:45 +0000 (UTC) (envelope-from dimpase@gmail.com) Received: by mail-lf0-x22a.google.com with SMTP id a16so2640657lfk.0 for ; Wed, 08 Nov 2017 03:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WvHD1gYrGifVQp3Y87Pj5K0qOGPpFI29CPv4W+CgW0c=; b=eFeA8Lgdx1rHwa2rLCuqp6/DUNBnoxeUwceUSu1C7x0EVl6N/58fNYW1xkia/grfTO k2uZzqCsg1SMkGu+0cl6aAVJuCgg9EqzwIq+E3Zc7r6kxpiFGgeslwHl1iRdON8eQTIY 9DdGMFMFlNFFW4gbsEb2w9iaCZfq8q9hkdD8aRCztpuAZeI2CNAld1ZfD3IT7ZcBqnXj o5BLk7c2t+urx+3Ic7ySNEDnmUm+jA5RhZJwXA0gviKRIOVyCUsxIamFo48Iq5lJmpXj uocqNqjdECOgbjj1fGbWdlE6eVfN13L5F1Nwd6C52hLltpzeeyPTA3FY5kzlFD9xN0Da aEKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WvHD1gYrGifVQp3Y87Pj5K0qOGPpFI29CPv4W+CgW0c=; b=Nua86Yh9m1kw2Ozp8bdX4nOLpCS9i7ntqNOqn37K3vqj68zHJLwtg9CpiVZpbL8se0 dZ4dXnxoDCjPw3uBVHCUp5k7tMA76npJKQ+goIKdRcGUpWfuSTsChLkPoYUOXf2So509 OYgIp+RluronEsV4hGUWIYHGSUAQi+KYJyPNi6GkXHW4AtOzOSCCGdE3t+Xa9CFqHo70 G6D4W9egnxvKrLoiIuy5YEAWBCiGA3S8WedSN6tOdUsIj10yEXTPyQle3MDhEo3sduth +cNnRyAvyU1yxSYtY+W7ygDdY0mbHraO/mhTIT4EV7fVhBbV562rTQ5MYe9wvoMp7qbo raBQ== X-Gm-Message-State: AJaThX5lnp9RnMzUVKzkLhBsBI9VydKQCBVA1Sz7sBXG08q21duTj3l+ SZ7WxXYmYwLQYtfpLDq9WCzZE8liDtcXEojx8Ws/LA== X-Google-Smtp-Source: ABhQp+RCotYF2MjM3+U82JIRUK0e4xQG8UNFh5GYKeH3SqLG7UD/A2WK8K7Rj3BdXYoiAntGBcHZ0XtD9CVxk6kRDo0= X-Received: by 10.46.83.67 with SMTP id t3mr38089ljd.135.1510138840952; Wed, 08 Nov 2017 03:00:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.46.29.68 with HTTP; Wed, 8 Nov 2017 03:00:40 -0800 (PST) Received: by 10.46.29.68 with HTTP; Wed, 8 Nov 2017 03:00:40 -0800 (PST) In-Reply-To: <20171108061501.GA51059@troutmask.apl.washington.edu> References: <20171106194937.GA87725@freebird> <20171106204121.GB37361@troutmask.apl.washington.edu> <20171106213308.GA73787@troutmask.apl.washington.edu> <20171108061501.GA51059@troutmask.apl.washington.edu> From: Dima Pasechnik Date: Wed, 8 Nov 2017 11:00:40 +0000 Message-ID: Subject: Re: cpow and clog To: Steve Kargl Cc: Eitan Adler , "Montgomery-Smith, Stephen" , "freebsd-numerics@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 11:00:45 -0000 On 8 Nov 2017 07:15, "Steve Kargl" wrote: On Tue, Nov 07, 2017 at 09:18:11PM -0800, Eitan Adler wrote: > On 7 November 2017 at 17:50, Montgomery-Smith, Stephen > wrote: > > >> Note, I packaged Bruce's code with manpages here > >> > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216863 > > > > Please, someone should commit it. > > :( Well, yes, a patch that sits in bugzilla tends to rot. A patch not tagged by a version control system surely rots very quickly, as noone except the submitter knows the exact state of the source tree it is made against, especially if the tree is also not under a revision control system. And surely the submitter's memory is not perfect, either. If your patches were made on a version control system, rebasing them would have been mist probably trivial, too (assuming it is just some permutation of commuting chunks of code causing patch to fail, as it most often the case). That is, one reason for these patches to move so slowly is simply very outdated workflow. Dima PS. The current freebsd workflow, using svn instead of git (as basically everyone else does nowadays) is also oudated, but by a much smaller margin. Still, at least if used properly, patches are perfectly traceable to the state of the source tree they are created at. PPS. yes, in case you may wonder, I have learnt to program using punch cards, almost 40 years ago :-) > patching file include/complex.h > Hunk #1 succeeded at 99 (offset 12 lines). > patching file lib/libc/softfloat/bits64/softfloat-macros > patching file lib/msun/Makefile > Hunk #2 succeeded at 134 (offset 3 lines). > Hunk #3 succeeded at 171 (offset 7 lines). > patching file lib/msun/Symbol.map > Hunk #1 FAILED at 294. Probably a trivial edit to deal with clog[fl] placed in different order of Symbol.map. > 1 out of 1 hunk FAILED -- saving rejects to file lib/msun/Symbol.map.rej > patching file lib/msun/man/clog.3 > patching file lib/msun/man/complex.3 > Hunk #1 succeeded at 24 with fuzz 2. > patching file lib/msun/src/math_private.h > Hunk #2 FAILED at 309. > 1 out of 2 hunks FAILED -- saving rejects to file > lib/msun/src/math_private.h.rej Don't know if someone has made change sot math_private.h. I guess I'll have to rebase my patch -- Steve _______________________________________________ freebsd-numerics@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-numerics To unsubscribe, send any mail to "freebsd-numerics-unsubscribe@freebsd.org"