From owner-freebsd-bugs  Wed Mar 14 16:10: 9 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 5BC0C37B71A
	for <freebsd-bugs@hub.freebsd.org>; Wed, 14 Mar 2001 16:10:03 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f2F0A3h96332;
	Wed, 14 Mar 2001 16:10:03 -0800 (PST)
	(envelope-from gnats)
Date: Wed, 14 Mar 2001 16:10:03 -0800 (PST)
Message-Id: <200103150010.f2F0A3h96332@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Seth Kingsley <sethk@osd.bsdi.com>
Subject: Re: bin/24654: /usr/bin/w doesn't close all files
Reply-To: Seth Kingsley <sethk@osd.bsdi.com>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

The following reply was made to PR bin/24654; it has been noted by GNATS.

From: Seth Kingsley <sethk@osd.bsdi.com>
To: freebsd-gnats-submit@FreeBSD.org, zartik@yahoo.com
Cc:  
Subject: Re: bin/24654: /usr/bin/w doesn't close all files
Date: Wed, 14 Mar 2001 16:00:39 -0800

 While all kvm_close() does currently is close() descriptors and free
 dynamic memory, it does seem like the right thing to always call it.
 
 Index: w.c
 ===================================================================
 RCS file: /ncvs/src/usr.bin/w/w.c,v
 retrieving revision 1.38
 diff -u -r1.38 w.c
 --- w.c	1999/11/17 15:28:45	1.38
 +++ w.c	2001/03/14 22:26:06
 @@ -407,6 +407,7 @@
  		longidle = pr_idle(ep->idle);
  		(void)printf("%.*s\n", argwidth - longidle, ep->args);
  	}
 +	(void)kvm_close(kd);
  	exit(0);
  }
  
 -- 
 || Seth Kingsley || BSDi/Open Source Division || sethk@osd.bsdi.com ||

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message