From owner-svn-src-head@FreeBSD.ORG Thu Sep 24 19:36:44 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1780A106566C for ; Thu, 24 Sep 2009 19:36:44 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id A44958FC31 for ; Thu, 24 Sep 2009 19:36:43 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.3/8.14.3) with ESMTP id n8OJYVtw026583; Thu, 24 Sep 2009 14:34:32 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.3/8.14.3/Submit) id n8OJYUGM026582; Thu, 24 Sep 2009 14:34:30 -0500 (CDT) (envelope-from brooks) Date: Thu, 24 Sep 2009 14:34:30 -0500 From: Brooks Davis To: Thomas Backman Message-ID: <20090924193430.GB26261@lor.one-eyed-alien.net> References: <200907241503.n6OF3ATP013228@svn.freebsd.org> <20090829201228.00005860@unknown> <20090904221432.GC82231@lor.one-eyed-alien.net> <20090906044700.5208ba62@gluon.draftnet> <20090908194311.GB32690@lor.one-eyed-alien.net> <5A148FA5-4B30-46AF-8A65-1B5E18F43C8B@exscape.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QKdGvSO+nmPlgiQ/" Content-Disposition: inline In-Reply-To: <5A148FA5-4B30-46AF-8A65-1B5E18F43C8B@exscape.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 24 Sep 2009 14:34:32 -0500 (CDT) Cc: Bruce Cran , svn-src-head@FreeBSD.org Subject: Re: svn commit: r195843 - in head: lib/libkvm sys/kern sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2009 19:36:44 -0000 --QKdGvSO+nmPlgiQ/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2009 at 01:08:08PM +0200, Thomas Backman wrote: > On Sep 8, 2009, at 9:43 PM, Brooks Davis wrote: >=20 >> On Sun, Sep 06, 2009 at 04:47:00AM +0100, Bruce Cran wrote: >>> On Fri, 4 Sep 2009 17:14:32 -0500 >>> Brooks Davis wrote: >>>=20 >>>> On Sat, Aug 29, 2009 at 08:12:28PM +0100, Bruce Cran wrote: >>>>> On Fri, 24 Jul 2009 15:03:10 +0000 (UTC) >>>>> Brooks Davis wrote: >>>>>=20 >>>>>> Author: brooks >>>>>> Date: Fri Jul 24 15:03:10 2009 >>>>>> New Revision: 195843 >>>>>> URL: http://svn.freebsd.org/changeset/base/195843 >>>>>>=20 >>>>>> Log: >>>>>> Revert the changes to struct kinfo_proc in r194498. Instead, >>>>>> fill in up to 16 (KI_NGROUPS) values and steal a bit from >>>>>> ki_cr_flags (all bits currently unused) to indicate overflow with >>>>>> the new flag KI_CRF_GRP_OVERFLOW. >>>>>>=20 >>>>>> This fixes procstat -s. >>>>>>=20 >>>>>> Approved by: re (kib) >>>>>=20 >>>>> Hi Brooks, >>>>>=20 >>>>> This checkin appears to have broken crash dump support: the bcopy in >>>>> kvm_proc.c crashes when running "ps -ax -M /var/crash/vmcore.x >>>>> -N /boot/kernel/kernel", apparently because ucred.cr_groups isn't >>>>> valid. Does it need converted using KVM_READ first? >>>>=20 >>>> Sorry for the delay, I believe you are correct we need to use kvm_read >>>> here instead of the bcopy. Do you still have a core handy you can >>>> test a patch against? The following should do it. >>>=20 >>> The patch has fixed the crash, and data is now returned too. >>=20 >> Thanks for testing! I've committed the patch and will MFC in the next >> week or so. > MFC coming up? The patch fixes the segfault for me as well, and this shou= ld=20 > *really* make it into 8.0. I got stalled by vacation and EuroBSDCon. I just sent in the MFC request. -- Brooks --QKdGvSO+nmPlgiQ/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFKu8nFXY6L6fI4GtQRAhwVAKCjzilKRGmC+Fa526Pq7+whmXkzXgCeJYN/ MtGnknmgle1ImRxiqWMCeBo= =oLER -----END PGP SIGNATURE----- --QKdGvSO+nmPlgiQ/--