From owner-svn-src-all@freebsd.org  Tue Dec  5 15:46:45 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A9F6E6E3CF;
 Tue,  5 Dec 2017 15:46:45 +0000 (UTC) (envelope-from devin@shxd.cx)
Received: from shxd.cx (mail.shxd.cx [64.201.244.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8A8167FA4A;
 Tue,  5 Dec 2017 15:46:45 +0000 (UTC) (envelope-from devin@shxd.cx)
Received: from [64.201.244.132] (port=54633 helo=[10.0.0.109])
 by shxd.cx with esmtps (TLSv1:AES256-SHA:256) (Exim 4.77 (FreeBSD))
 (envelope-from <devin@shxd.cx>)
 id 1eMFQX-000MHT-1z; Tue, 05 Dec 2017 15:46:33 +0000
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge
 usr.bin/sponge/tests usr.bin/tee
From: Devin Teske <devin@shxd.cx>
X-Mailer: iPhone Mail (13G36)
In-Reply-To: <CAG6CVpW2N16jKMNnU22NDKH8A2oOzu0BcCLvsqrUrXXUxmuQvw@mail.gmail.com>
Date: Tue, 5 Dec 2017 07:46:43 -0800
Cc: Eitan Adler <eadler@freebsd.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <8090FD05-E35B-4BC2-A89C-281EE8EBAA0B@shxd.cx>
References: <201712050355.vB53tApl074041@repo.freebsd.org>
 <CAG6CVpXGATey4VC6u0seN=3Sb+zvYTve9bJ9WY+pUDtPJjHHkw@mail.gmail.com>
 <CAG6CVpW2N16jKMNnU22NDKH8A2oOzu0BcCLvsqrUrXXUxmuQvw@mail.gmail.com>
To: cem@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Dec 2017 15:46:45 -0000


> On Dec 4, 2017, at 8:40 PM, Conrad Meyer <cem@freebsd.org> wrote:
>=20
>> On Mon, Dec 4, 2017 at 8:30 PM, Conrad Meyer <cem@freebsd.org> wrote:
>>> On Mon, Dec 4, 2017 at 7:55 PM, Eitan Adler <eadler@freebsd.org> wrote:
>>> Author: eadler
>>> Date: Tue Dec  5 03:55:10 2017
>>> New Revision: 326554
>>> URL: https://svnweb.freebsd.org/changeset/base/326554
>>>=20
>>> Log:
>>>  sponge(1): initial commit
>>>=20
>>>  sponge(1) is a utility that reads input until
>>>  complete, then opens the output file, then
>>>  writes to it. This makes it useful in pipelines
>>>  that read and write to the same file.
>>>=20
>>>  Reviewed by:  wblock, jilles, imp, cem, danfe (all: various iterations)=

>>=20
>> I don't recall reviewing this in any iteration, but I could be mistaken.
>>=20
>> Best,
>> Conrad
>=20
> In fact I don't think any of the listed reviewers approved the change,
> at least in phabricator.  The "Reviewed by" line signifies not just
> giving feedback, but approval of the final (or near-final) change.
>=20
> Best,
> Conrad
>=20

If true, upsetting. You have people like myself that are ultra patient and w=
ait for the approvals. For example, https://reviews.freebsd.org/D10006 which=
 has been in review for 8 months now and I have been working on it for a tot=
al of 5 years now.

It is more than a little hurtful to put in such effort and then see someone e=
lse run roughshod past the group.
--=20
Devin=