From owner-freebsd-bugs Fri Apr 6 6:42: 1 2001 Delivered-To: freebsd-bugs@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id D52F337B43C for ; Fri, 6 Apr 2001 06:41:57 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id XAA32712; Fri, 6 Apr 2001 23:41:52 +1000 Date: Fri, 6 Apr 2001 23:39:59 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Peter Pentchev Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/26317: /modules not created by make installkernel In-Reply-To: <20010406145604.A447@ringworld.oblivion.bg> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Fri, 6 Apr 2001, Peter Pentchev wrote: > On Wed, Apr 04, 2001 at 04:13:25PM +1000, Bruce Evans wrote: > > On Tue, 3 Apr 2001, Peter Pentchev wrote: > > > I wonder, though, whether the 'installkernel' target in Makefile.inc1 should > > > not, too, invoke a 'make hierarchy', or at least some subset of that, to do > > > an mtree from BSD.root.dist; that should ensure that the /modules directory > > > is there. > > > > No more than sh/Makefile should invoke a 'make hierarchy', or at least some > > subset of that, to recover from /bin somehow not existing. > > So, basically, are you saying that this is not a problem and this PR should > be closed, or do you think the installkernel target should at least make > an attempt at doing the right thing in case of a user mess-up, and just > mkdir ${DESTDIR}/modules? I would close it. Using mkdir would be wrong since it might get the directory ownership or permissions wrong. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message