From owner-cvs-all@FreeBSD.ORG  Tue Jan 23 08:31:03 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 84EDE16A401;
	Tue, 23 Jan 2007 08:31:03 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 42BB913C4C1;
	Tue, 23 Jan 2007 08:31:03 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l0N8Rv9D085202;
	Tue, 23 Jan 2007 01:27:57 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Tue, 23 Jan 2007 01:28:23 -0700 (MST)
Message-Id: <20070123.012823.1341031192.imp@bsdimp.com>
To: nate@root.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <45B5AE3B.6010005@root.org>
References: <20070122043408.4171816A492@hub.freebsd.org>
	<45B5AE3B.6010005@root.org>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Tue, 23 Jan 2007 01:27:57 -0700 (MST)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jan 2007 08:31:03 -0000

In message: <45B5AE3B.6010005@root.org>
            Nate Lawson <nate@root.org> writes:
: Warner Losh wrote:
: > imp         2007-01-22 04:34:03 UTC
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     sys/cam/scsi         scsi_da.c 
: >   Log:
: >   Add quirk for EasyMP3 EM732X usb 2.0 flash mp3 player.
: >   (It appears that the quirk proceedures link has disappeared and that
: >   this PR complied with it, if there's a problem, please contact me).
: >   
: >   PR: usb/96546
: >   
: >   Revision  Changes    Path
: >   1.201     +8 -0      src/sys/cam/scsi/scsi_da.c
: > 
: > 
: > Index: src/sys/cam/scsi/scsi_da.c
: > diff -u src/sys/cam/scsi/scsi_da.c:1.200 src/sys/cam/scsi/scsi_da.c:1.201
: > --- src/sys/cam/scsi/scsi_da.c:1.200	Tue Dec  5 07:45:28 2006
: > +++ src/sys/cam/scsi/scsi_da.c	Mon Jan 22 04:34:03 2007
: > @@ -466,6 +466,14 @@
: >  		{T_DIRECT, SIP_MEDIA_REMOVABLE, "X-Micro", "Flash Disk",
: >  		"*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
: >  	},
: > +	{
: > +		/*
: > +		 * EasyMP3 EM732X USB 2.0 Flash MP3 Player
: > +		 * PR: usb/96546
: > +		 */
: > +		{T_DIRECT, SIP_MEDIA_REMOVABLE, "*", "MP3 Player*",
: > +		"1.0"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
: > +	},
: >  };
: >  
: >  static	disk_strategy_t	dastrategy;
: 
: Um, this matches every device that has "MP3 Player" somewhere in it. 
: Are you sure it doesn't have a vendor string?

See the PR for details and suggest something better.

Warner