From owner-svn-src-head@freebsd.org Wed Apr 29 15:20:46 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 891142B8238; Wed, 29 Apr 2020 15:20:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49C2Jt1yGcz4M29; Wed, 29 Apr 2020 15:20:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id 03TFKU3L016674 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 29 Apr 2020 18:20:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 03TFKU3L016674 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id 03TFKU28016673; Wed, 29 Apr 2020 18:20:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 29 Apr 2020 18:20:30 +0300 From: Konstantin Belousov To: Michal Meloun Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r360463 - head/libexec/rtld-elf Message-ID: <20200429152030.GB2522@kib.kiev.ua> References: <202004291406.03TE6g1c031338@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202004291406.03TE6g1c031338@repo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 49C2Jt1yGcz4M29 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.990,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:20:46 -0000 On Wed, Apr 29, 2020 at 02:06:42PM +0000, Michal Meloun wrote: > Author: mmel > Date: Wed Apr 29 14:06:42 2020 > New Revision: 360463 > URL: https://svnweb.freebsd.org/changeset/base/360463 > > Log: > Don't allow to use FPU inside of rtld library. > Clang10 may use FPU instructions for optimizing operations with > memory blocks. But we don't want to do lengthy save/restore of all > FPU registers across each rtld_start() call. > > MFC after: 3 week > > Modified: > head/libexec/rtld-elf/Makefile > > Modified: head/libexec/rtld-elf/Makefile > ============================================================================== > --- head/libexec/rtld-elf/Makefile Wed Apr 29 13:45:21 2020 (r360462) > +++ head/libexec/rtld-elf/Makefile Wed Apr 29 14:06:42 2020 (r360463) > @@ -48,6 +48,9 @@ MLINKS?= rtld.1 ld-elf.so.1.1 \ > rtld.1 ld.so.1 > > CFLAGS+= -fpic -DPIC $(DEBUG) > +CFLAGS.armv6+= -mfpu=none > +CFLAGS.armv7+= -mfpu=none I cleaned rtld-elf/Makefile of all MD bits, please move this to arm/Makefile.inc. > + > LDFLAGS+= -shared -Wl,-Bsymbolic -Wl,-z,defs -nostdlib -e ${RTLD_ENTRY} > # Pull in the dependencies that we use from libc > .include "rtld-libc/Makefile.inc"