From owner-freebsd-current@FreeBSD.ORG  Thu Nov 24 03:25:55 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3B09F1065673;
	Thu, 24 Nov 2011 03:25:55 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail03.syd.optusnet.com.au (mail03.syd.optusnet.com.au
	[211.29.132.184])
	by mx1.freebsd.org (Postfix) with ESMTP id B28668FC0A;
	Thu, 24 Nov 2011 03:25:54 +0000 (UTC)
Received: from c211-28-227-231.carlnfd1.nsw.optusnet.com.au
	(c211-28-227-231.carlnfd1.nsw.optusnet.com.au [211.28.227.231])
	by mail03.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	pAO3PpxX020118
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 24 Nov 2011 14:25:52 +1100
Date: Thu, 24 Nov 2011 14:25:51 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Robert Millan <rmh@freebsd.org>
In-Reply-To: <20111123070036.GA29952@thorin>
Message-ID: <20111124141821.O932@besplex.bde.org>
References: <20111123070036.GA29952@thorin>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Mailman-Approved-At: Thu, 24 Nov 2011 04:54:55 +0000
Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>,
	freebsd-current@freebsd.org, freebsd-arch@freebsd.org
Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Nov 2011 03:25:55 -0000

On Wed, 23 Nov 2011, Robert Millan wrote:

> Here we go again :-)
>
> Out of the kernel headers that are installed in /usr/include/ hierracy, there
> are some which include support multiple operating systems (usually FreeBSD and
> other *BSD flavours).
>
> This patch adds support to detect GNU/kFreeBSD as well.  In all cases, we
> match the same declarations as FreeBSD does (which is to be expected in kernel
> headers, since both systems share the same kernel).

Now it adds lots of namespace pollution (all of <sys/param.h>, including
all of its namespace pollution), just to get 1 new symbol defined.

% Index: sys/cam/scsi/scsi_low.h
% ===================================================================
% --- sys/cam/scsi/scsi_low.h	(revision 227831)
% +++ sys/cam/scsi/scsi_low.h	(working copy)
% @@ -44,6 +44,8 @@
%  #ifndef	_SCSI_LOW_H_
%  #define	_SCSI_LOW_H_
% 
% +#include <sys/param.h>
% +
%  /*================================================
%   * Scsi low OSDEP 
%   * (All os depend structures should be here!)
% 
% [... 22 more headers polluted]

All the affected headers are poorly implemented ones.  Mostly kernel
headers which escaped to userland.

Bruce