From owner-cvs-sys Sat Mar 22 12:51:26 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA29420 for cvs-sys-outgoing; Sat, 22 Mar 1997 12:51:26 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA29397; Sat, 22 Mar 1997 12:51:17 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.3/8.6.9) id HAA11304; Sun, 23 Mar 1997 07:47:58 +1100 Date: Sun, 23 Mar 1997 07:47:58 +1100 From: Bruce Evans Message-Id: <199703222047.HAA11304@godzilla.zeta.org.au> To: ache@nagual.ru, bde@freefall.freebsd.org Subject: Re: syscons & time access (was Re: cvs commit: src/sys/nfs nfs_socket.c nfs_syscalls.c nfs_vnops.c src/sys/ufs/ffs ffs_alloc.c ffs_inode.c ffs_vfsops.c ffs_vnops.c src/sys/ufs/lfs lfs_inode.c lfs_vnops.c src/sys/ufs/ufs ufs_inode.c ufs_readwrite.c ufs_vnops.c src/sys/gnu/ext2fs ext2_alloc.c ext2_extern.h ext2_inode.c ext2_readwrite.c ext2_vnops.c src/sys/i386/isa/pcvt pcvt_kbd.c src/sys/kern init_main.c kern_clock.c sys_pipe.c tty.c src/sys/pci ncr.c src/sys/sys time.h) Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> Fixed some invalid (non-atomic) accesses to `time', mostly ones of the >> form `tv = time'. Use a new function gettime(). The current version >syscons.c have a number of non-atomic time accesses too, do you plan to >fix them too? Not soon. They are all of the form time.tv_sec, which is atomic on i386's, at least with CC=gcc. Syscons should use mono_time instead of `time', since `time' may go backwards or jump forwards. This bug just causes screen savers to be started to early or too late. Bruce