From owner-freebsd-ports@FreeBSD.ORG Thu Dec 6 23:23:35 2007 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DE0B16A421 for ; Thu, 6 Dec 2007 23:23:35 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmmtao102.cox.net (eastrmmtao102.cox.net [68.230.240.8]) by mx1.freebsd.org (Postfix) with ESMTP id F14C513C4D3 for ; Thu, 6 Dec 2007 23:23:34 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmimpo02.cox.net ([68.1.16.120]) by eastrmmtao102.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20071206232334.KPHB16464.eastrmmtao102.cox.net@eastrmimpo02.cox.net>; Thu, 6 Dec 2007 18:23:34 -0500 Received: from mezz.mezzweb.com ([24.255.149.218]) by eastrmimpo02.cox.net with bizsmtp id MbPG1Y0074iy4EG0000000; Thu, 06 Dec 2007 18:23:16 -0500 Date: Thu, 06 Dec 2007 17:28:48 -0600 To: GP From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 References: <002401c8352b$9ba33750$6300000a@pi> <001c01c835f6$8165ab90$6300000a@pi> <000801c83672$46c079d0$6300000a@pi> <007601c83804$4b014c20$6300000a@pi> Content-Transfer-Encoding: Quoted-Printable Message-ID: In-Reply-To: <007601c83804$4b014c20$6300000a@pi> User-Agent: Opera Mail/9.24 (Linux) Cc: freebsd-ports@freebsd.org Subject: Re: HELP needed by experienced porter for simple review X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2007 23:23:35 -0000 On Thu, 06 Dec 2007 06:34:05 -0600, GP wrote: >> - Respect the CC, CFLAGS and LOCALBASE. See in post-patch. >> - Add kissdx.in in 'files' directory. >> - Remove that add_to_conf stuff in Makefile, use pkg-message. > > Thank you Mezz, for going through my makefiles and making it conform t= o = > the principals of > the ports system. No problem. > That was a very big help to me and an effort beyond expectation. > It gave me a new understanding of /files that I will pass on to the do= c = > team and > hopefully into the next version of porters handbook. > > rc.conf > It's a shame that I can't use a script placed in /files to change = > rc.conf during install/ > deinstall. I really liked that. But i guess I will settle with a dull = = > pkg-message at the > end, like the rest of you... I dislike any ports to touch in my /etc/*. :-) > Source Makefile > Since I made the (simple) source Makefile, I would have liked to take = = > advantage of the > many predefined macros/variables i the port Makefile. > It seems strange to me, to pass them as a patch (like this: s|CC?=3D = > gcc|CC?=3D ${CC}|g ) > > How many of them if any, are passed on to the source makefile? Are the= re = > a way to turn > them all on? if that: any documentation? (except the bsd.ports.mk file= ) The CC part is documented in the porter handbook, I believe. Same as wit= h = CFLAGS. Cheers, Mezz > BR, Simon -- = mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org http://wiki.freebsd.org/multimedia - multimedia@FreeBSD.org