From owner-freebsd-ports  Fri Nov 24  8:48:28 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from mail.icehouse.net (mail.icehouse.net [204.203.53.2])
	by hub.freebsd.org (Postfix) with ESMTP id B845A37B4CF
	for <ports@FreeBSD.org>; Fri, 24 Nov 2000 08:48:24 -0800 (PST)
Received: from deimos.walker.dom (ppp-209.icehouse.net [204.203.52.209])
	by mail.icehouse.net (8.9.3/8.9.3/Debian 8.9.3-21) with ESMTP id IAA09715;
	Fri, 24 Nov 2000 08:48:19 -0800
X-Authentication-Warning: mail.icehouse.net: Host ppp-209.icehouse.net [204.203.52.209] claimed to be deimos.walker.dom
Received: from mars.walker.dom (mars.walker.dom. [192.168.0.1])
	by deimos.walker.dom (8.11.1/8.11.1) with SMTP id eAOGmEi05801;
	Fri, 24 Nov 2000 08:48:15 -0800 (PST)
	(envelope-from kew@icehouse.net)
From: Keith Walker <kew@icehouse.net>
Date: Fri, 24 Nov 2000 08:48:14 -0800
X-Mailer: KMail [version 1.1.99]
Content-Type: text/plain;
  charset="big5"
Cc: ports@FreeBSD.org
To: Kevin Lo <kevin.lo@toptk.com>
References: <00112309141700.21980@mars.walker.dom> <3A1DC01A.B015C06F@toptk.com>
In-Reply-To: <3A1DC01A.B015C06F@toptk.com>
Subject: Re: FreeBSD Port: kdemultimedia2-2.0
MIME-Version: 1.0
Message-Id: <00112408481400.01336@mars.walker.dom>
Content-Transfer-Encoding: 8bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On Thursday 23 November 2000  5:10, Kevin Lo wrote:
> Keith Walker wrote:
> > Hi!
>
> Hi Keith,
>
> > I installed KDE2 a while back and I'd been wondering whatever happened to
> > the kscd program (the CD Player) ever since.
>
> Great :-) Thanks for your feedback.
>
> > Well, I went looking at the thing and discovered a few problems with easy
> > solutions that make the program work.
>
> I've done the following instructions before. Compiled with no problems, but
> starting kscd, I got core dumped :-(
> I'm trying to find what the problem is and will fix it ASAP.
> That's why I didn't release my patches.
> Does anyone follow instructions and kcsd works fine? If so, I'll release my
> patches for kdemultimedia2.
>

The core dump problem has been there for sooo long: something to do with it 
not finding the cdrom device. My limited abilities have never been able to 
track that one down. If the cdrom device exists, permissions are adequate, 
and we can open it, all is well.

This patch keeps the kscd from crashing, but kscd is still mysteriously quiet 
about what's happening. Unless you start it from the command line and see all 
of the errors going by, you're kinda lost, but at least it doesn't crash.

--- plat_freebsd.c.orig	Fri Nov 24 08:41:04 2000
+++ plat_freebsd.c	Fri Nov 24 08:42:14 2000
@@ -49,7 +49,7 @@
 #include <sys/time.h>
 #include <sys/ioctl.h>
 #include <sys/cdio.h>
-#include <sys/scsiio.h>
+/*#include <sys/scsiio.h>*/
 
 #if defined(__NetBSD__)
 # define MSF_MINUTES 1
@@ -102,6 +102,7 @@
   char vendor[32] = WM_STR_GENVENDOR;
   char  model[32] = WM_STR_GENMODEL;
   char    rev[32] = WM_STR_GENREV;
+  int		retval = 0;
   
   if (d->fd >= 0)		/* Device already open? */
     {
@@ -127,7 +128,7 @@
 	}
       
       /* No CD in drive. */
-      return (1);
+      retval = 1;
     }
   
   if (warned)
@@ -142,11 +143,9 @@
   *d = *(find_drive_struct(vendor, model, rev));
   wm_drive_settype(vendor, model, rev);
   
-  (d->init)(d);
-  
   d->fd = fd;
-  
-  return (0);
+  (d->init)(d);
+  return retval;
 } /* wmcd_open() */
 
 /*


-- 
Keith Walker
kew@icehouse.net


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message