From owner-freebsd-bugs@freebsd.org  Mon Oct 24 05:08:15 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 50924C1F3F5
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Mon, 24 Oct 2016 05:08:15 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 409CD921
 for <freebsd-bugs@FreeBSD.org>; Mon, 24 Oct 2016 05:08:15 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u9O58FOU061055
 for <freebsd-bugs@FreeBSD.org>; Mon, 24 Oct 2016 05:08:15 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 213736] pf: hardcoded if_output skips ip[6]_output and pfil order
Date: Mon, 24 Oct 2016 05:08:15 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: franco@opnsense.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-213736-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2016 05:08:15 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213736

            Bug ID: 213736
           Summary: pf: hardcoded if_output skips ip[6]_output and pfil
                    order
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: franco@opnsense.org

Hi,

Up until now pf_route[6] uses code copied from ip_output[6] to push packets=
 to
their destination for the tags route-to, reply-to and dup-to. The packet is
consumed on the spot.

>From an architectural standpoint of pfil, this undermines its consistency:
Packets must either be consumed when they are dropped or when they are dela=
yed
(dummynet).

In case of ipfw, PACKET_TAG_FORWARD is used to store the hext hop for the
forward tag and evaluated properly outside the pfil hooks.  The same could =
be
done for pf, but it's not a crucial requirement.

Skipping the full ip_output[6] code in favour of a stub has other side effe=
cts
and fixing it would help align the packet processing consistency.

Of prime interest are productive combinations of ipfw+pf that in case of
route-to et al simply stop working as pf consumes all its traffic up front.


Cheers,
Franco

--=20
You are receiving this mail because:
You are the assignee for the bug.=