From owner-freebsd-arch@FreeBSD.ORG Tue May 7 20:27:25 2013 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 8CF7E327; Tue, 7 May 2013 20:27:25 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-bk0-x234.google.com (mail-bk0-x234.google.com [IPv6:2a00:1450:4008:c01::234]) by mx1.freebsd.org (Postfix) with ESMTP id EC2A8FF0; Tue, 7 May 2013 20:27:24 +0000 (UTC) Received: by mail-bk0-f52.google.com with SMTP id q16so518978bkw.11 for ; Tue, 07 May 2013 13:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=732HaSfgza7QxyvrcoFufnMsPM4m+AZAieBu7XGT3e0=; b=xMpMqrfn77AN/0JVUjnrlaB2MIFU0t1aJpv2P4zI20jxgF5pMXF35QrgyHBs7+IS89 XKJiV0bNdGhYAX8o3mO+0LxRWR7Q8GvF9wJpXOi4K++LBvN2NaXL+BW89PoEPnyB8hMu AyQm0IAYEBrXUF9ItrqSTANcDaFszqpEEKxkxZiEjSz7iz2+kyUre881Xh8RNFKsLTCF WIpxmqOK8hgf5AoFYUiNPwbtpKBvexGODgTlcTnNC7vsnYWB5JQULmcgyTxiXx3kUkMD o/6AzfbVNb4GARHVnq5rbW3y+Lz1F/s2r7gDbysR2vUwaJRYl1lfRL6eG0Q/OFx3f9fc 5Yqg== MIME-Version: 1.0 X-Received: by 10.204.244.198 with SMTP id lr6mr1038392bkb.1.1367958444071; Tue, 07 May 2013 13:27:24 -0700 (PDT) Received: by 10.204.225.206 with HTTP; Tue, 7 May 2013 13:27:24 -0700 (PDT) In-Reply-To: <51896021.6010900@delphij.net> References: <51896021.6010900@delphij.net> Date: Tue, 7 May 2013 13:27:24 -0700 Message-ID: Subject: Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree From: Garrett Cooper To: Xin LI Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "freebsd-arch@FreeBSD.org Arch" , freebsd-toolchain@freebsd.org, "Simon J. Gerraty" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 May 2013 20:27:25 -0000 On Tue, May 7, 2013 at 1:12 PM, Xin Li wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > On 05/07/13 13:05, Garrett Cooper wrote: > > Hi, A common pattern that I've seen at Isilon and something else > > that I've wanted to have for a while is the ability to designate > > where the top of a source tree was. This is important and helpful > > when dealing with source files that build upon each other or depend > > on sources located in other sections of the tree; contrib stuff > > needs to set .PATH appropriately to point to sources at the top of > > the tree, sys stuff is riddled with S= in order to point to where > > /sys, etc lives, we build upon FreeBSD within an expected directory > > structure as well. I haven't come up with a name, but was wondering > > if this was a good idea, and if so does anyone have any outstanding > > patches for this that can be pushed into FreeBSD? > > Is there anything wrong with the current '../../' approach? > Not in particular, other than our variable (ISI_TOP) is used in referencing ${.CURDIR} and ${.OBJDIR}, and it's easy to make mistakes if you goof up the dot-dots. With a properly defined directory like that it makes things unambiguous in my mind and with a proper name it makes pathing more intuitive than it currently is. Besides, it would make some other things cleaner, like the dot-dot magic that config(8), etc does. Thanks! -Garrett