From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Aug 20 02:40:24 2003
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9CEE416A4BF
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed, 20 Aug 2003 02:40:24 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 88FF243FE0
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed, 20 Aug 2003 02:40:13 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7K9eCUp089842
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Wed, 20 Aug 2003 02:40:12 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7K9eC4i089841;
	Wed, 20 Aug 2003 02:40:12 -0700 (PDT)
Resent-Date: Wed, 20 Aug 2003 02:40:12 -0700 (PDT)
Resent-Message-Id: <200308200940.h7K9eC4i089841@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Dmitry Sivachenko <mitya@demos.su>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9333216A4BF
	for <FreeBSD-gnats-submit@freebsd.org>;
	Mon, 18 Aug 2003 23:27:26 -0700 (PDT)
Received: from tear.demos.su (tear.demos.su [194.87.2.103])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9292543F85
	for <FreeBSD-gnats-submit@freebsd.org>;
	Mon, 18 Aug 2003 23:27:25 -0700 (PDT)
	(envelope-from mitya@tear.demos.su)
Received: (from mitya@localhost)
	by tear.demos.su (8.12.9/8.12.9) id h7J6RHRp034659;
	Tue, 19 Aug 2003 10:27:17 +0400 (MSD)
	(envelope-from mitya)
Message-Id: <200308190627.h7J6RHRp034659@tear.demos.su>
Date: Tue, 19 Aug 2003 10:27:17 +0400 (MSD)
From: Dmitry Sivachenko <mitya@demos.su>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Subject: ports/55721: "Checking if XXX already installed" does not work
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Aug 2003 09:40:24 -0000


>Number:         55721
>Category:       ports
>Synopsis:       "Checking if XXX already installed" does not work
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 20 02:40:11 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry Sivachenko
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
Demos-Internet
>Environment:
System: FreeBSD tear.demos.su 4.8-STABLE FreeBSD 4.8-STABLE #0: Tue Jul 22 10:49:22 MSD 2003 mitya@tear.demos.su:/usr/src/sys/compile/TEAR i386


bsd.port.mk rev 1.462

>Description:

Though $found_package variable is properly populated, it is checked for 
non-zero length ( -n "$${found_package}" ) in another shell process where it
does not exist.

>How-To-Repeat:

Install a port of your choice.  Increase PORTVERSION and try to install the
same port again.  It will be installed, instead of displaying expected warning.

>Fix:

--- bsd.port.mk.old	Tue Aug 19 10:20:01 2003
+++ bsd.port.mk	Tue Aug 19 10:20:31 2003
@@ -3040,8 +3040,8 @@
 								fi; \
 						fi; \
 				done; \
-		fi;
-		@if [ -d ${PKG_DBDIR}/${PKGNAME} -o -n "$${found_package}" ]; then \
+		fi; \
+		if [ -d ${PKG_DBDIR}/${PKGNAME} -o -n "$${found_package}" ]; then \
 				if [ -d ${PKG_DBDIR}/${PKGNAME} ]; then \
 						${ECHO_CMD} "===>   ${PKGNAME} is already installed"; \
 				else \
>Release-Note:
>Audit-Trail:
>Unformatted: